From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>
Subject: Re: [PATCHv2 4/5] dt-bindings: net: wireless: ath9k: add OF bindings
Date: Fri, 23 May 2025 08:24:00 +0200 [thread overview]
Message-ID: <4b1960f2-95e4-41c3-9723-04d77c6c27d4@kernel.org> (raw)
In-Reply-To: <CAKxU2N8uZ+q1aE42+e65tVMr=ji0RTx5wZssFBnQN29OzsFXVA@mail.gmail.com>
On 23/05/2025 02:04, Rosen Penev wrote:
> On Thu, May 22, 2025 at 12:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 22/05/2025 20:45, Rosen Penev wrote:
>>> Now that support was added to the driver, document it.
>>
>> That's not appropriate commit msg. Binding must be before the user (see
>> submitting patches in DT directory). Describe the hardware, what are you
>> adding here.
>>
>> Subject: OF bindings is redundant. It duplicates dt-bindings. Instead:
>> "Add Atheros AR9-foo-bar on AHB bus" or something similar
> At this point I wonder if my approach is wrong. The other ath drivers
> use a qcom, prefix and a -wifi suffix. Might make sense to do the same
> here to avoid typing qca twice.
Yes, probably this should be qcom.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-23 6:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 18:45 [PATCHv2 0/5] wifi: ath9k: add ahb OF support Rosen Penev
2025-05-22 18:45 ` [PATCHv2 1/5] wifi: ath9k: ahb: reorder declarations Rosen Penev
2025-05-22 18:45 ` [PATCHv2 2/5] wifi: ath9k: ahb: reorder includes Rosen Penev
2025-05-22 18:45 ` [PATCHv2 3/5] wifi: ath9k: ahb: replace id_table with of Rosen Penev
2025-05-22 18:45 ` [PATCHv2 4/5] dt-bindings: net: wireless: ath9k: add OF bindings Rosen Penev
2025-05-22 19:54 ` Krzysztof Kozlowski
2025-05-23 0:04 ` Rosen Penev
2025-05-23 6:24 ` Krzysztof Kozlowski [this message]
2025-05-22 18:45 ` [PATCHv2 5/5] mips: dts: qca: add wmac support Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1960f2-95e4-41c3-9723-04d77c6c27d4@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=toke@toke.dk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).