From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A4722E9EC0 for ; Tue, 2 Sep 2025 09:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756804935; cv=none; b=BoTwtIo1u7W1oq15TEVfJVFrRPDYOxhAt72WlhsErWLg9VYN2RxSCGudF4auLV7IMHzwL/3xfHCFwDXDbUVJKHgdGHzkj2lm8i/0wFW8upppRP3VHcBVijk/c01APYfr0SOdJR5QQmCzDPXEK+ym71iJ1VfBpXcRXnVI0i/9lAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756804935; c=relaxed/simple; bh=Pv1NlzKjL0xFo8BfGbhy/7KnNZN8WrItjraHEOkXixw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kzTZP6ZDMNgQfDToWsJCVoQX5vZT3zSvnGxa8OZJkExt6ZA2c5yv+Pu1GN9o9l6rgQL7pt10eVIeIO5QYiEvm6A1JJUYoMMxFmT2yNKAe6dam8p8lFc4jOAYKB47hifww5UAO2l01Qt7klrb/qY4Z/yTi+b901mKfZIvef1mKAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net; spf=none smtp.mailfrom=ursulin.net; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b=BjJ4DkI0; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ursulin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b="BjJ4DkI0" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45b8b2712d8so22268695e9.3 for ; Tue, 02 Sep 2025 02:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin-net.20230601.gappssmtp.com; s=20230601; t=1756804931; x=1757409731; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Be300C9M54HN2j6qqn3KzILYOn0Dm/rUn/s4aJntRQ=; b=BjJ4DkI0nOIeBWi829gHdcdGEnRHe1ZnQO1njdb+Jyp0kjPhbqnc/pH3IqlbX/mPRt KImIiC5IOBhDUsCOe+bsijMfqcLKa+dXYa461vlf8W43jDTp2NN/HyQttUmEPfTyMDsa +znjOYbf7zmMPfsw7iujVXgeGLUXtwGXlQ+SY2EucQk11hSB12zyiFkHuuLs1Vp+GMQK znrByajiS5QwRXsCGGX/uEAkboujg3cDsCxXhSDvaaKtpi9xTJYSIPVmQMJW+nANv+26 x3bpMDTCAYkVqg6BQ0C/DVGa/O/iwl4l6QGYI8jJHyq5e0aZ7lgtishdDOyJn3yv5f02 d/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756804931; x=1757409731; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Be300C9M54HN2j6qqn3KzILYOn0Dm/rUn/s4aJntRQ=; b=ocsaNlFU5melF/mPDsShBd+PhKWwuh7w6ST6+K1TJQHsDM/NL46MjaX8m1ZQVPfQ3c CBfVt6hUOUb1Ta5zbq4F1KWnvaFWjHTy6s0e22gGg8P1AbtT9yPJK1pPH+Kkl34wh6bM k8A9C90iRhtplSMqGSpMlI9kdUQ2jDLB7Hi8oI81SgIiQPCUagvyAngygiZthkSyVc1z ZqbIQiO+ZeHyo1VorbFWSsBNCit2SOgzIWJ46Tv4UZm3c4B44ECKdp19+XGQaFUfWK0g TyNA6fjzFh/CCFg+aG3xRbdYyxjXl8okykiIiC3pB4VmCufv5MBXyhiH70vphhHPeevq DLPA== X-Forwarded-Encrypted: i=1; AJvYcCU2U/WZYDnaO0gt4qN2DaNp3l0BEb6rZ3HVNMlPpkDk4r+Z+ykU7iHoMi8yM6WsAgwpQHusIvsYeP7U@vger.kernel.org X-Gm-Message-State: AOJu0YybUciTGZUHb1QTuyjIajhyYWoJgXLLrELobEOfAS9c2hB727d/ 0aGc852NZr06ceM3YDcMTPQmiJvtHXDW906uszqMms/a7AY05GD43Le7uLK4xsQLY2M= X-Gm-Gg: ASbGncsCaDboRT4H97oDb3swN5q++ACQ5HpqBB2SZDTaFSZb3NKqvQn6Kegp4tfjZTK VWScf9XDMipTI0BgMaw1Pr+L7Ba6HtGMHf1swyl9tzPCjXkaEO8F2u7bkog7Bd0qYx0k322wGho EQ4tpQU1kcmY/LhRafcJcUiRziTQG3a5O9MHWqL6Hgm5u4yBXMFrst2F3e4o0pbBgseOoj6/PI5 Htlkh+jjB5F1TXCd21xFj/GFtnXp0Rh2QihDcG2uIUrkGOf2kH2/k+ODMepD+g1Gki+M1bNt16I Y/NQ34/ww1ka445KiC3yAm9SXBdlANAvIu5VKaNXasnQKEwV7kme3HLF5umXS81xPflHDb8Q4NA LWcwqnaEthy8ac6FlvvImGpyDzeIKaYAEzdY= X-Google-Smtp-Source: AGHT+IFjGWdM7r4OC2xPYq10JBW42QzIVS9ISDbv655toZnOdc57tKWSkMByc2ni755H7QY3mBnVYA== X-Received: by 2002:a05:600c:a04:b0:45b:7d24:beac with SMTP id 5b1f17b1804b1-45b8553335amr94619035e9.10.1756804930815; Tue, 02 Sep 2025 02:22:10 -0700 (PDT) Received: from [192.168.0.101] ([84.66.36.92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3d0b9402299sm17994846f8f.18.2025.09.02.02.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 02:22:10 -0700 (PDT) Message-ID: <4bbf5590-7591-4dfc-a23e-0bda6cb31a80@ursulin.net> Date: Tue, 2 Sep 2025 10:22:09 +0100 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 26/37] drm/i915/gem: drop nth_page() usage within SG entry To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: Lorenzo Stoakes , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Simona Vetter , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan References: <20250901150359.867252-1-david@redhat.com> <20250901150359.867252-27-david@redhat.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20250901150359.867252-27-david@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/09/2025 16:03, David Hildenbrand wrote: > It's no longer required to use nth_page() when iterating pages within a > single SG entry, so let's drop the nth_page() usage. > > Reviewed-by: Lorenzo Stoakes > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: David Airlie > Cc: Simona Vetter > Signed-off-by: David Hildenbrand > --- > drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > index c16a57160b262..031d7acc16142 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > @@ -779,7 +779,7 @@ __i915_gem_object_get_page(struct drm_i915_gem_object *obj, pgoff_t n) > GEM_BUG_ON(!i915_gem_object_has_struct_page(obj)); > > sg = i915_gem_object_get_sg(obj, n, &offset); > - return nth_page(sg_page(sg), offset); > + return sg_page(sg) + offset; > } > > /* Like i915_gem_object_get_page(), but mark the returned page dirty */ LGTM. If you want an ack to merge via a tree other than i915 you have it. I suspect it might be easier to coordinate like that. Regards, Tvrtko