From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aleksander Bajkowski <olek2@wp.pl>,
tsbogend@alpha.franken.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-mips@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mips: lantiq: Document Lantiq SoC dt bindings
Date: Tue, 28 Mar 2023 08:32:21 +0200 [thread overview]
Message-ID: <4fcb67bf-aa12-61c3-ca30-3fb11eaba67a@linaro.org> (raw)
In-Reply-To: <b3e0502b-61d0-430e-8832-dbbec69035a5@wp.pl>
On 27/03/2023 23:21, Aleksander Bajkowski wrote:
>>> +properties:
>>> + $nodename:
>>> + const: "/"
>>> + compatible:
>>> + oneOf:
>>> + - description: Boards with Lantiq Amazon-SE SoC
>>> + items:
>>> + - const: lantiq,ase
>> This does not look like proper board compatible. Boards have almost
>> always minimum two compatibles - one for SoC and one for board. With
>> commit msg this just adds to confusion...
>>
>
> The added dt-binding contains only the SoC part. The compatible strings
> for individual boards will be added later together with the dts files. Before
> sending the dts files I want to document current bindings and clear
> checkpach warnings about undocumented strings.
Which is incomplete and inaccurate documentation. Instead, document
proper, full compatibles.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-28 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 12:29 [PATCH] dt-bindings: mips: lantiq: Document Lantiq SoC dt bindings Aleksander Jan Bajkowski
2023-03-26 14:54 ` Krzysztof Kozlowski
2023-03-27 21:21 ` Aleksander Bajkowski
2023-03-28 6:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fcb67bf-aa12-61c3-ca30-3fb11eaba67a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).