From: David Daney <ddaney.cavm@gmail.com>
To: Jim Quinlan <jim2101024@gmail.com>, ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, cernekee@gmail.com
Subject: Re: [PATCH V4 0/3] MIPS: make funcs preempt-safe for non-mipsr2 cpus
Date: Wed, 05 Sep 2012 16:45:12 -0700 [thread overview]
Message-ID: <5047E408.4060009@gmail.com> (raw)
In-Reply-To: <1346884367-6906-1-git-send-email-jim2101024@gmail.com>
On 09/05/2012 03:32 PM, Jim Quinlan wrote:
> This is V4 of my submission. Here is a list of requested changes:
>
> o Extra commit was added for changing an unsigned short to an int.
> o Use of EXTERN_SYMBOL was added to mips-atomic.c and bitops.c,
> as well as the removal of 'extern' in the functions' declarations.
> o Name of funcs changed from atomic_xxx to __mips_xxx in bitops.c.
> o The function comments in bitops.c were tweaked to please
> scripts/kernel-doc.
>
> Here is a list of requested changes that were not done (and why):
>
> o Suggested optimization of _MIPS_SZLONG and others was not needed
> as mips-atomic.c now includes <asm/irqflags.h>.
> o Suggested fixes to please checkpatch.pl for whitespace before
> newlines in asm strings was attempted but the result made the
> assembly code look more cluttered => no change made.
>
> These were unrequested changes:
> o Changed order of func listings in irqflags.h so that only one
> #ifdef/#endif pair was needed instead of three.
>
> Jim Quinlan
>
FWIW: I haven't tested these, but...
Acked-by: David Daney <david.daney@cavium.com>
Thanks for your patience,
David Daney
prev parent reply other threads:[~2012-09-05 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 22:32 [PATCH V4 0/3] MIPS: make funcs preempt-safe for non-mipsr2 cpus Jim Quinlan
2012-09-05 22:32 ` [PATCH V4 1/3] MIPS: bitops.h: change use of 'unsigned short' to 'int' Jim Quinlan
2012-09-05 22:32 ` [PATCH V4 2/3] MIPS: Remove irqflags.h dependency from bitops.h Jim Quinlan
2012-09-05 22:32 ` [PATCH V4 3/3] MIPS: make funcs preempt-safe for non-mipsr2 cpus Jim Quinlan
2012-09-05 23:45 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5047E408.4060009@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=cernekee@gmail.com \
--cc=jim2101024@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox