Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: "Jayachandran C." <c.jayachandran@gmail.com>,
	Ralf Baechle <ralf@linux-mips.org>
Cc: Jacob Burkholder <jacob.burkholder@blinqnetworks.com>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: Re: linux 3.6.3 mips64 mtd jffs2 unmount issue
Date: Tue, 30 Oct 2012 10:36:39 -0700	[thread overview]
Message-ID: <50901027.6090802@gmail.com> (raw)
In-Reply-To: <CA+7sy7CWkcsg9YffJ-rcdN7D=vZtuees31upGzgUya5puDN0og@mail.gmail.com>

On 10/30/2012 01:09 AM, Jayachandran C. wrote:
[...]

>
> We had seen the same issue here, and worked around it the same way
> (i.e use dynamic allocation for the backing dev structures).
>
> I ran across a similar issue in using built-in DTB (basically, kernel
> data address does not work for virt_to_phys/phys_to_virt in 64-bit
> when the load address is in CKSEG0).  There I did something like this:
>
> ptr = phys_to_virt(__pa(kernel_data_ptr));
>
> This works since __pa knows about CKSEG0 addresses in 64bit.
>
>

Really the proper fix is to make virt_to_phys() work.  This isn't the 
only case where we have seen failures due to this issue:


http://www.linux-mips.org/archives/linux-mips/2011-09/msg00029.html

I fixed it like this...

In io.h:

static inline unsigned long virt_to_phys(volatile const void *address)
{
	return __pa(address);
}

Really this needs to be pushed upstream by somebody.

> JC.
>
>
>

  reply	other threads:[~2012-10-30 17:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-29 20:51 linux 3.6.3 mips64 mtd jffs2 unmount issue Jacob Burkholder
2012-10-30  8:09 ` Jayachandran C.
2012-10-30 17:36   ` David Daney [this message]
2012-10-30 20:28     ` Jacob Burkholder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50901027.6090802@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=c.jayachandran@gmail.com \
    --cc=jacob.burkholder@blinqnetworks.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox