From: Florian Fainelli <florian@openwrt.org>
To: Jonas Gorski <jogo@openwrt.org>
Cc: "Steven J. Hill" <sjhill@mips.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH v2] MIPS: dsp: Add assembler support for DSP ASEs.
Date: Mon, 17 Dec 2012 10:46:51 +0100 [thread overview]
Message-ID: <50CEEA0B.6030606@openwrt.org> (raw)
In-Reply-To: <CAOiHx==V+owqPzFRgSYqz2VYtQoq8XevpJgfmwQLyxdLZ-52qQ@mail.gmail.com>
Le 12/16/12 12:42, Jonas Gorski a écrit :
> On 15 December 2012 06:06, Steven J. Hill <sjhill@mips.com> wrote:
>> (snip)
>> diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile
>> index 33a96a9..c3c8cba 100644
>> --- a/arch/mips/kernel/Makefile
>> +++ b/arch/mips/kernel/Makefile
>> @@ -98,4 +98,31 @@ obj-$(CONFIG_HW_PERF_EVENTS) += perf_event_mipsxx.o
>>
>> obj-$(CONFIG_JUMP_LABEL) += jump_label.o
>>
>> +#
>> +# DSP ASE supported for MIPS32 or MIPS64 Release 2 cores only
>> +#
>> +ifeq ($(CONFIG_CPU_MIPSR2), y)
>> +CFLAGS_DSP = -DHAVE_AS_DSP
>
> 24K (non-E) is MIPS32r2, but not not implement any DSP ASEs, is this a
> problem here?
I do not think it is, all code-paths making use of the rddsp() wrdsp()
macros are checking cpu_has_dsp() so we should be pretty safe here. It
might be worth adding this comment to the Makefile though.
--
Florian
prev parent reply other threads:[~2012-12-17 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 5:06 [PATCH v2] MIPS: dsp: Add assembler support for DSP ASEs Steven J. Hill
2012-12-16 11:42 ` Jonas Gorski
2012-12-17 9:46 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CEEA0B.6030606@openwrt.org \
--to=florian@openwrt.org \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox