From: Sergei Shtylyov <sshtylyov@mvista.com>
To: John Crispin <blogic@openwrt.org>
Cc: Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/2] serial: ralink: adds support for the serial core found on ralink wisoc
Date: Fri, 25 Jan 2013 15:40:56 +0400 [thread overview]
Message-ID: <51026F48.1060106@mvista.com> (raw)
In-Reply-To: <1359111008-9998-1-git-send-email-blogic@openwrt.org>
Hello.
On 25-01-2013 14:50, John Crispin wrote:
> The MIPS based Ralink WiSoC platform has 1 or more 8250 compatible serial cores.
> To make them work we require the same quirks that are used by AU1x00.
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
> drivers/tty/serial/8250/8250.c | 6 +++---
> drivers/tty/serial/8250/Kconfig | 8 ++++++++
> include/linux/serial_core.h | 2 +-
> 3 files changed, 12 insertions(+), 4 deletions(-)
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index f932043..b727779 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -324,9 +324,9 @@ static void default_serial_dl_write(struct uart_8250_port *up, int value)
> serial_out(up, UART_DLM, value >> 8 & 0xff);
> }
>
> -#ifdef CONFIG_MIPS_ALCHEMY
> +#if defined(CONFIG_MIPS_ALCHEMY) || defined(CONFIG_SERIAL_8250_RT288X)
>
> -/* Au1x00 UART hardware has a weird register layout */
> +/* Au1x00 RT288x UART hardware has a weird register layout */
^
You need either comma or slash or "and" between those...
WBR, Sergei
prev parent reply other threads:[~2013-01-25 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 10:50 [PATCH 1/2] serial: ralink: adds support for the serial core found on ralink wisoc John Crispin
2013-01-25 10:50 ` [PATCH 2/2] serial: of: allow au1x00 and rt288x to load from OF John Crispin
2013-01-25 11:44 ` Sergei Shtylyov
2013-01-25 12:40 ` Greg KH
2013-01-25 11:40 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51026F48.1060106@mvista.com \
--to=sshtylyov@mvista.com \
--cc=alan@linux.intel.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox