From: Hauke Mehrtens <hauke@hauke-m.de>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, zajec5@gmail.com,
linux-mips@linux-mips.org
Subject: Re: [PATCH v4 0/5] watchdog: bcm47xx_wdt.c: add support for SoCs with PMU
Date: Mon, 28 Jan 2013 23:06:03 +0100 [thread overview]
Message-ID: <5106F64B.6040801@hauke-m.de> (raw)
In-Reply-To: <20130128213544.GB3338@spo001.leaseweb.com>
On 01/28/2013 10:35 PM, Wim Van Sebroeck wrote:
> Hi Hauke,
>
>> what is the status of these patches?
>
> First reading/checking (v4+v5) seems OK.
> 1 small remark allready: the settimeout functions seem to check the min and max timeout values.
> Can't you use the min and max values of the watchdog structure for this?
>
> Kind regards,
> Wim.
>
Hi Wim,
The max_timer_ms attribute in struct bcm47xx_wdt contains the maximum
value the hardware is capable of, the watchdog driver uses a softtimer
if this value is too low and in that case it is no problem if a
userspace application sets the timeout to some value higher than
max_timer_ms.
If I would use max_timeout from struct watchdog_device I would have to
change that values when softtimer is selected.
The best solution would be if the softtimer choice and implementation
would go to watchdog_dev.c as some more watchdog driver do something
similar.
Hauke
next prev parent reply other threads:[~2013-01-28 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 17:14 [PATCH v4 0/5] watchdog: bcm47xx_wdt.c: add support for SoCs with PMU Hauke Mehrtens
2013-01-12 17:14 ` [PATCH v4 1/5] watchdog: bcm47xx_wdt.c: convert to watchdog core api Hauke Mehrtens
2013-01-12 17:14 ` [PATCH v4 2/5] watchdog: bcm47xx_wdt.c: use platform device Hauke Mehrtens
2013-01-24 17:13 ` [PATCH v5 " Hauke Mehrtens
2013-01-12 17:14 ` [PATCH v4 3/5] watchdog: bcm47xx_wdt.c: rename ops methods Hauke Mehrtens
2013-01-12 17:14 ` [PATCH v4 4/5] watchdog: bcm47xx_wdt.c: rename wdt_time to timeout Hauke Mehrtens
2013-01-12 17:14 ` [PATCH v4 5/5] watchdog: bcm47xx_wdt.c: add hard timer Hauke Mehrtens
2013-01-24 17:15 ` [PATCH v4 0/5] watchdog: bcm47xx_wdt.c: add support for SoCs with PMU Hauke Mehrtens
2013-01-28 21:35 ` Wim Van Sebroeck
2013-01-28 22:06 ` Hauke Mehrtens [this message]
2013-02-07 22:29 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5106F64B.6040801@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox