From: Gabor Juhos <juhosg@openwrt.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>,
John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 3/4] MIPS: pci-ar724x: remove static PCI IO/MEM resources
Date: Sun, 03 Feb 2013 13:31:49 +0100 [thread overview]
Message-ID: <510E58B5.9060107@openwrt.org> (raw)
In-Reply-To: <510E479C.4020305@mvista.com>
2013.02.03. 12:18 keltezéssel, Sergei Shtylyov írta:
>> @@ -160,6 +163,16 @@ ath79_register_pci_ar724x(int id,
>> res[2].start = irq;
>> res[2].end = irq;
>>
>> + res[3].name = "mem_base";
>> + res[3].flags = IORESOURCE_MEM;
>> + res[3].start = mem_base;
>> + res[3].end = mem_base + mem_size - 1;
>> +
>> + res[4].name = "io_base";
>> + res[4].flags = IORESOURCE_IO;
>> + res[4].start = io_base;
>> + res[4].end = io_base;
>
> One I/O port, hm? What is it good for?
Strictly speaking it is not good for anything. This is a PCIe controller and it
does not support IO requests at all. However the whole PCI code assumes that
each PCI controller have an IO resource and uses the hose->io_resource pointer
unconditionally.
Additionally, this matches with the removed static resource:
> -static struct resource ar724x_io_resource = {
> - .name = "PCI IO space",
> - .start = 0,
> - .end = 0,
> - .flags = IORESOURCE_IO,
> -};
> -
Thank you for the review.
-Gabor
next prev parent reply other threads:[~2013-02-03 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 10:58 [PATCH 1/4] MIPS: ath79: allow to specify bus number in PCI IRQ maps Gabor Juhos
2013-02-03 10:58 ` [PATCH 2/4] MIPS: pci-ar724x: use dynamically allocated PCI controller structure Gabor Juhos
2013-02-03 10:59 ` [PATCH 3/4] MIPS: pci-ar724x: remove static PCI IO/MEM resources Gabor Juhos
2013-02-03 11:18 ` Sergei Shtylyov
2013-02-03 12:31 ` Gabor Juhos [this message]
2013-02-04 12:13 ` Sergei Shtylyov
2013-02-04 13:14 ` Gabor Juhos
2013-02-03 11:00 ` [PATCH 4/4] MIPS: pci-ar724x: use per-controller IRQ base Gabor Juhos
2013-02-03 15:52 ` [PATCH 5/4] MIPS: pci-ar724x: setup command register of the PCI controller Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510E58B5.9060107@openwrt.org \
--to=juhosg@openwrt.org \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox