From: Gabor Juhos <juhosg@openwrt.org>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>,
"Rodriguez, Luis" <rodrigue@qca.qualcomm.com>,
"Giori, Kathy" <kgiori@qca.qualcomm.com>,
QCA Linux Team <qca-linux-team@qca.qualcomm.com>
Subject: Re: [PATCH 02/11] MIPS: ath79: add SoC detection code for the QCA955X SoCs
Date: Fri, 15 Feb 2013 17:42:20 +0100 [thread overview]
Message-ID: <511E656C.5080501@openwrt.org> (raw)
In-Reply-To: <511E5BB8.8060800@openwrt.org>
2013.02.15. 17:00 keltezéssel, John Crispin írta:
>
>>
>> - sprintf(ath79_sys_type, "Atheros AR%s rev %u", chip, rev);
>> + if (soc_is_qca955x())
>> + sprintf(ath79_sys_type, "Qualcomm Atheros QCA%s rev %u",
>> + chip, rev);
>> + else
>> + sprintf(ath79_sys_type, "Atheros AR%s rev %u", chip, rev);
>> pr_info("SoC: %s\n", ath79_sys_type);
>> }
>>
> Hi,
>
> maybe a soc_is_qca() could be used here, otherwise you will need to patch this
> line again for the next SoC and so on ....
Hm, if I would add a soc_is_qca() macro, I would have to patch that macro for
the next SoCs instead of this line.
Maybe it would be better to add the AR/QCA prefix to each chip name, and use
'Qualcomm Atheros' unconditionally in the sprintf call?
-Gabor
next prev parent reply other threads:[~2013-02-15 16:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 14:38 [PATCH 00/11] MIPS: ath79: add support for the QCA955X SoCs Gabor Juhos
2013-02-15 14:38 ` [PATCH 01/11] MIPS: ath79: add early printk " Gabor Juhos
2013-02-15 14:38 ` [PATCH 02/11] MIPS: ath79: add SoC detection code " Gabor Juhos
2013-02-15 16:00 ` John Crispin
2013-02-15 16:42 ` Gabor Juhos [this message]
2013-02-15 14:38 ` [PATCH 03/11] MIPS: ath79: add clock setup " Gabor Juhos
2013-02-15 14:38 ` [PATCH 04/11] MIPS: ath79: add IRQ handling " Gabor Juhos
2013-02-15 16:01 ` John Crispin
2013-02-15 17:26 ` Gabor Juhos
2013-02-15 14:38 ` [PATCH 05/11] MIPS: ath79: add GPIO setup " Gabor Juhos
2013-02-15 14:38 ` [PATCH 06/11] MIPS: ath79: add QCA955X specific glue to ath79_device_reset_{set,clear} Gabor Juhos
2013-02-15 14:38 ` [PATCH 07/11] MIPS: ath79: register UART for the QCA955X SoCs Gabor Juhos
2013-02-15 14:38 ` [PATCH 08/11] MIPS: ath79: add WMAC registration code " Gabor Juhos
2013-02-15 16:01 ` John Crispin
2013-02-15 17:13 ` Gabor Juhos
2013-02-15 14:38 ` [PATCH 09/11] MIPS: ath79: add PCI controller " Gabor Juhos
2013-02-15 14:38 ` [PATCH 10/11] MIPS: ath79: add USB " Gabor Juhos
2013-02-15 14:38 ` [PATCH 11/11] MIPS: ath79: add support for the Qualcomm Atheros AP136-010 board Gabor Juhos
2013-02-15 16:02 ` John Crispin
2013-02-15 17:34 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511E656C.5080501@openwrt.org \
--to=juhosg@openwrt.org \
--cc=blogic@openwrt.org \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-mips@linux-mips.org \
--cc=qca-linux-team@qca.qualcomm.com \
--cc=ralf@linux-mips.org \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox