From: Lars-Peter Clausen <lars@metafoo.de>
To: Steven Hill <Steven.Hill@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Kristian Kielhofner <kris@krisk.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: sead3_led: Use LED_CORE_SUSPENDRESUME
Date: Wed, 20 Feb 2013 21:42:25 +0100 [thread overview]
Message-ID: <51253531.90001@metafoo.de> (raw)
In-Reply-To: <0573B2AE5BBFFC408CC8740092293B5ACB3CB7@bamail02.ba.imgtec.org>
On 02/20/2013 09:31 PM, Steven Hill wrote:
> Hello.
>
> This patch does not apply cleanly because of space/tab differences. In both of the lines below with '.brightness_set' the character between 't' and '=' needs to be a tab, not a space.
>
> -Steve
Hi,
The patch depends on commit 70342287 ("MIPS: Whitespace cleanup.").
- Lars
>
>
> @@ -34,33 +34,15 @@ static void sead3_fled_set(struct led_classdev *led_cdev,
> static struct led_classdev sead3_pled = {
> .name = "sead3::pled",
> .brightness_set = sead3_pled_set,
> + .flags = LED_CORE_SUSPENDRESUME,
> };
>
> static struct led_classdev sead3_fled = {
> .name = "sead3::fled",
> .brightness_set = sead3_fled_set,
> + .flags = LED_CORE_SUSPENDRESUME,
> };
>
next prev parent reply other threads:[~2013-02-20 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-17 12:28 [PATCH] MIPS: sead3_led: Use LED_CORE_SUSPENDRESUME Lars-Peter Clausen
2013-02-20 20:31 ` Steven Hill
2013-02-20 20:42 ` Lars-Peter Clausen [this message]
2013-02-20 20:44 ` Steven Hill
2013-02-20 21:02 ` Lars-Peter Clausen
2013-02-20 21:07 ` Steven Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51253531.90001@metafoo.de \
--to=lars@metafoo.de \
--cc=Steven.Hill@imgtec.com \
--cc=kris@krisk.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox