From: David Daney <ddaney.cavm@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>, Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
Subject: Re: MIPS: Add dependencies for HAVE_ARCH_TRANSPARENT_HUGEPAGE
Date: Mon, 04 Mar 2013 10:13:00 -0800 [thread overview]
Message-ID: <5134E42C.9050509@gmail.com> (raw)
In-Reply-To: <1362370641.3768.291.camel@deadeye.wl.decadent.org.uk>
On 03/03/2013 08:17 PM, Ben Hutchings wrote:
> The MIPS implementation of transparent huge-pages (THP) is 64-bit only,
> and of course also requires that the CPU supports huge-pages.
>
> Currently it's entirely possible to enable THP in other configurations,
> which then fail to build due to pfn_pmd() not being defined.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: David Daney <david.daney@cavium.com>
This is correct.
Acked-by: David Daney <david.daney@cavium.com>
> ---
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -19,7 +19,7 @@ config MIPS
> select HAVE_KRETPROBES
> select HAVE_DEBUG_KMEMLEAK
> select ARCH_BINFMT_ELF_RANDOMIZE_PIE
> - select HAVE_ARCH_TRANSPARENT_HUGEPAGE
> + select HAVE_ARCH_TRANSPARENT_HUGEPAGE if CPU_SUPPORTS_HUGEPAGES && 64BIT
> select RTC_LIB if !MACH_LOONGSON
> select GENERIC_ATOMIC64 if !64BIT
> select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
>
next prev parent reply other threads:[~2013-03-04 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 20:51 THP broken on MIPS-32 [3.8] Ben Hutchings
2013-03-04 4:17 ` MIPS: Add dependencies for HAVE_ARCH_TRANSPARENT_HUGEPAGE Ben Hutchings
2013-03-04 18:13 ` David Daney [this message]
2013-03-12 14:07 ` Ralf Baechle
2013-03-20 22:33 ` Sebastian Gottschall
2013-03-20 23:12 ` David Daney
2013-03-21 0:16 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5134E42C.9050509@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=ben@decadent.org.uk \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox