From: Gabor Juhos <juhosg@openwrt.org>
To: John Crispin <john@phrozen.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] pci: convert to devm_ioremap_resource()
Date: Mon, 11 Mar 2013 11:14:01 +0100 [thread overview]
Message-ID: <513DAE69.30207@openwrt.org> (raw)
In-Reply-To: <513DAAAA.1050003@phrozen.org>
2013.03.11. 10:58 keltezéssel, John Crispin írta:
> On 11/03/13 11:00, Gabor Juhos wrote:
>> 2013.03.11. 8:42 keltezéssel, Silviu-Mihai Popescu írta:
>>> Convert all uses of devm_request_and_ioremap() to the newly introduced
>>> devm_ioremap_resource() which provides more consistent error handling.
>>>
>>> devm_ioremap_resource() provides its own error messages so all explicit
>>> error messages can be removed from the failure code paths.
>>>
>>> Signed-off-by: Silviu-Mihai Popescu<silviupopescu1990@gmail.com>
>>> ---
>>> arch/mips/pci/pci-ar724x.c | 18 +++++++++---------
>>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> Acked-by: Gabor Juhos<juhosg@openwrt.org>
>>
>> Just a minor note, arch/mips/pci/pci-ar71xx.c should be fixed as well probably.
>>
>>
>
>
> Hi,
>
> is this patch supposed to go upstream via linux-mips.org ?
Yes, IMHO.
-Gabor
prev parent reply other threads:[~2013-03-11 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 7:42 [PATCH] pci: convert to devm_ioremap_resource() Silviu-Mihai Popescu
2013-03-11 10:00 ` Gabor Juhos
2013-03-11 9:58 ` John Crispin
2013-03-11 10:14 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DAE69.30207@openwrt.org \
--to=juhosg@openwrt.org \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox