From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Gabor Juhos <juhosg@openwrt.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 02/18] MIPS: ralink: fix RT305x clock setup
Date: Wed, 10 Apr 2013 17:49:22 +0400 [thread overview]
Message-ID: <51656DE2.4000300@cogentembedded.com> (raw)
In-Reply-To: <1365594447-13068-3-git-send-email-blogic@openwrt.org>
Hello.
On 10-04-2013 15:47, John Crispin wrote:
> Add a few missing clocks and remove the unused sys clock.
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
> arch/mips/ralink/rt305x.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> diff --git a/arch/mips/ralink/rt305x.c b/arch/mips/ralink/rt305x.c
> index 0a4bbdc..856ebff 100644
> --- a/arch/mips/ralink/rt305x.c
> +++ b/arch/mips/ralink/rt305x.c
[...]
> @@ -176,11 +177,24 @@ void __init ralink_clk_init(void)
> BUG();
> }
>
> + if (soc_is_rt3352() || soc_is_rt5350()) {
> + u32 val = rt_sysc_r32(RT3352_SYSC_REG_SYSCFG0);
Empty line wouldn't hurt here...
> + if ((val & RT3352_CLKCFG0_XTAL_SEL) == 0)
Using ! would make this shorter.
WBR, Sergei
next prev parent reply other threads:[~2013-04-10 13:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 11:47 [PATCH 00/18] MIPS: ralink: add several new Ralink SoC John Crispin
2013-04-10 11:47 ` [PATCH 01/18] MIPS: ralink: add PCI IRQ handling John Crispin
2013-04-10 11:47 ` [PATCH 02/18] MIPS: ralink: fix RT305x clock setup John Crispin
2013-04-10 13:47 ` Jonas Gorski
2013-04-10 13:49 ` Sergei Shtylyov [this message]
2013-04-10 11:47 ` [PATCH 03/18] MIPS: ralink: add missing comment in irq driver John Crispin
2013-04-10 11:47 ` [PATCH 04/18] MIPS: ralink: add RT5350 sdram register defines John Crispin
2013-04-10 11:47 ` [PATCH 05/18] MIPS: ralink: add RT3352 usb " John Crispin
2013-04-10 11:47 ` [PATCH 06/18] MIPS: ralink: add pinmux driver John Crispin
2013-04-10 13:51 ` Jonas Gorski
2013-04-10 11:47 ` [PATCH 07/18] MIPS: ralink: extend RT3050 dtsi file John Crispin
2013-04-10 11:47 ` [PATCH 08/18] MIPS: ralink: add RT5350 " John Crispin
2013-04-10 13:53 ` Jonas Gorski
2013-04-10 13:54 ` John Crispin
2013-04-10 11:47 ` [PATCH 09/18] MIPS: ralink: make early_printk work on RT2880 John Crispin
2013-04-10 11:47 ` [PATCH 10/18] MIPS: ralink: adds support for RT2880 SoC family John Crispin
2013-04-10 11:47 ` [PATCH 11/18] MIPS: ralink: add rt2880 dts files John Crispin
2013-04-10 11:47 ` [PATCH 12/18] MIPS: ralink: adds support for RT3883 SoC family John Crispin
2013-04-10 11:47 ` [PATCH 13/18] MIPS: ralink: add rt3883 dts files John Crispin
2013-04-10 11:47 ` [PATCH 14/18] MIPS: ralink: adds support for MT7620 SoC family John Crispin
2013-04-10 11:47 ` [PATCH 15/18] MIPS: ralink: add MT7620 dts files John Crispin
2013-04-10 11:47 ` [PATCH 16/18] MIPS: ralink: add support for periodic timer irq John Crispin
2013-04-10 13:41 ` Lars-Peter Clausen
2013-04-10 11:47 ` [PATCH 17/18] MIPS: ralink: add cpu-feature-overrides.h John Crispin
2013-04-10 11:47 ` [PATCH 18/18] MIPS: ralink: add support for runtime memory detection John Crispin
2013-04-10 13:56 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51656DE2.4000300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=blogic@openwrt.org \
--cc=juhosg@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox