From: John Crispin <john@phrozen.org>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: John Crispin <blogic@openwrt.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: move mips_{set,get}_machine_name() to a more generic place
Date: Fri, 12 Apr 2013 19:46:10 +0200 [thread overview]
Message-ID: <51684862.5000306@phrozen.org> (raw)
In-Reply-To: <516845AB.8080109@openwrt.org>
Am 4/12/13 7:34 PM, schrieb Gabor Juhos:
> Any specific reason why you are using snprintf? If someone would call this with
> format characters in the 'name' that would cause weird things.
strncpy makes more sense indeed. the code i copied used strdup, which
failed as memory was not available at the time the code ran
prev parent reply other threads:[~2013-04-12 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 6:34 [PATCH] MIPS: move mips_{set,get}_machine_name() to a more generic place John Crispin
2013-04-11 7:10 ` John Crispin
2013-04-12 17:34 ` Gabor Juhos
2013-04-12 17:46 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51684862.5000306@phrozen.org \
--to=john@phrozen.org \
--cc=blogic@openwrt.org \
--cc=juhosg@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox