From: Florian Fainelli <florian@openwrt.org>
To: Jonas Gorski <jogo@openwrt.org>
Cc: dedekind1@gmail.com, linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Maxime Bizon <mbizon@freebox.fr>,
Kevin Cernekee <cernekee@gmail.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] MIPS: BCM63XX: export PSI size from nvram
Date: Sun, 12 May 2013 16:52:47 +0200 [thread overview]
Message-ID: <518FACBF.4040606@openwrt.org> (raw)
In-Reply-To: <CAOiHx=m+ZuBcj=qmTtytWouCbtbj+_OX3dS8x_0=kHEBFZ+TmA@mail.gmail.com>
Le 12/05/2013 12:48, Jonas Gorski a écrit :
> On Fri, May 10, 2013 at 2:36 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
>> On Sat, 2013-03-23 at 14:07 +0100, Jonas Gorski wrote:
>>> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
>>> ---
>>> arch/mips/bcm63xx/nvram.c | 11 +++++++++++
>>> arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h | 2 ++
>>> 2 files changed, 13 insertions(+)
>>
>> Acks from MIPS folks would be nice to have, but I pushed this patch to
>> the l2-mtd.git tree, thanks!
>
> I had expected Florian's valid comment from preventing this series
> from going in, but if you pushed it already then I will fix the return
> type problem that Florian pointed out in a separate patch (or rather
> add add some range check for nvram.psi_size). Luckily it is a
> theoretical issue only, as I haven't seen a device yet with an invalid
> value.
Right, but this is no blocker from my perspective. As about the MIPS
folks, Maxime, Kevin, Jonas and myself have been the "historical"
contributors to the MIPS BCM63XX port, so I would consider Jonas to be
authoritave here for these paches. John and Ralf usually do not comment
unless the see something bad.
--
Florian
next prev parent reply other threads:[~2013-05-12 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 13:07 [PATCH 0/3] fix NVRAM partition size if larger than expected Jonas Gorski
2013-03-23 13:07 ` [PATCH 1/3] MTD: bcm63xxpart: use size macro for CFE block size Jonas Gorski
2013-03-23 13:07 ` [PATCH 2/3] MIPS: BCM63XX: export PSI size from nvram Jonas Gorski
2013-03-23 13:39 ` Florian Fainelli
2013-05-10 12:36 ` Artem Bityutskiy
2013-05-12 10:48 ` Jonas Gorski
2013-05-12 14:52 ` Florian Fainelli [this message]
2013-03-23 13:07 ` [PATCH 3/3] MTD: bcm63xxpart: use nvram for PSI size Jonas Gorski
2013-03-23 13:39 ` [PATCH 0/3] fix NVRAM partition size if larger than expected Florian Fainelli
2013-05-10 12:35 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518FACBF.4040606@openwrt.org \
--to=florian@openwrt.org \
--cc=cernekee@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox