From: David Daney <ddaney.cavm@gmail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>,
"Steven J. Hill" <sjhill@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Trap exception handling fixes
Date: Thu, 23 May 2013 10:00:37 -0700 [thread overview]
Message-ID: <519E4B35.10507@gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1305231744460.26443@tp.orcam.me.uk>
On 05/23/2013 09:54 AM, Maciej W. Rozycki wrote:
> On Thu, 23 May 2013, Maciej W. Rozycki wrote:
>
>> It looks to me do_bp would benefit from some polishing too.
>
> To make myself more clear here -- there are two microMIPS BREAK encodings
> of which do_bp assumes (without checking!) the 32-bit one, that is
> actually unlikely to be ever present in compiler-generated code (so how
> was this change validated?),
Probably sjhill should answer that, as they are his patches.
David Daney
> and also the MIPS16 path is special-cased
> (makes a separate call to do_trap_or_bp), which I find error-prone in
> long-term maintenance.
>
> Maciej
>
>
>
next prev parent reply other threads:[~2013-05-23 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 15:31 [PATCH] MIPS: Trap exception handling fixes Maciej W. Rozycki
2013-05-23 15:31 ` Maciej W. Rozycki
2013-05-23 15:50 ` Ralf Baechle
2013-05-23 16:07 ` Maciej W. Rozycki
2013-05-23 16:07 ` Maciej W. Rozycki
2013-05-23 16:54 ` Maciej W. Rozycki
2013-05-23 16:54 ` Maciej W. Rozycki
2013-05-23 17:00 ` David Daney [this message]
2013-05-24 6:23 ` Steven J. Hill
2013-05-24 6:45 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E4B35.10507@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@codesourcery.com \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox