From: Chen Gang <gang.chen@asianux.com>
To: ralf@linux-mips.org, blogic@openwrt.org
Cc: linux-mips@linux-mips.org, Linux-Arch <linux-arch@vger.kernel.org>
Subject: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()
Date: Sun, 26 May 2013 15:51:49 +0800 [thread overview]
Message-ID: <51A1BF15.7070905@asianux.com> (raw)
'compatible' is used by strlen() in __of_device_is_compatible().
So for NUL terminated string, need always be sure of ended by zero.
'of_ids' is not a structure in "include/uapi/*", so not need initialize
all bytes, just use strlcpy() instead of strncpy().
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/mips/lantiq/prom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
index 9f9e875..49c4603 100644
--- a/arch/mips/lantiq/prom.c
+++ b/arch/mips/lantiq/prom.c
@@ -112,7 +112,7 @@ int __init plat_of_setup(void)
if (!of_have_populated_dt())
panic("device tree not present");
- strncpy(of_ids[0].compatible, soc_info.compatible,
+ strlcpy(of_ids[0].compatible, soc_info.compatible,
sizeof(of_ids[0].compatible));
strncpy(of_ids[1].compatible, "simple-bus",
sizeof(of_ids[1].compatible));
--
1.7.7.6
next reply other threads:[~2013-05-26 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 7:51 Chen Gang [this message]
2013-05-28 12:29 ` [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy() John Crispin
2013-05-29 1:29 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A1BF15.7070905@asianux.com \
--to=gang.chen@asianux.com \
--cc=blogic@openwrt.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox