From: John Crispin <blogic@openwrt.org>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH] arch: mips: kernel: using strlcpy() instead of strncpy()
Date: Mon, 27 May 2013 12:38:49 +0200 [thread overview]
Message-ID: <51A337B9.60402@openwrt.org> (raw)
In-Reply-To: <51A1C26E.5000609@asianux.com>
On 26/05/13 10:06, Chen Gang wrote:
> For NUL terminated string, need always be sure of ended by zero.
>
> Or the next pr_info() will cause issue.
>
>
> Signed-off-by: Chen Gang<gang.chen@asianux.com>
> ---
> arch/mips/kernel/prom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/kernel/prom.c b/arch/mips/kernel/prom.c
> index 5712bb5..7e95404 100644
> --- a/arch/mips/kernel/prom.c
> +++ b/arch/mips/kernel/prom.c
> @@ -30,7 +30,7 @@ __init void mips_set_machine_name(const char *name)
> if (name == NULL)
> return;
>
> - strncpy(mips_machine_name, name, sizeof(mips_machine_name));
> + strlcpy(mips_machine_name, name, sizeof(mips_machine_name));
> pr_info("MIPS: machine is %s\n", mips_get_machine_name());
> }
>
Acked-by: John Crispin <blogic@openwrt.org>
prev parent reply other threads:[~2013-05-27 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 8:06 [PATCH] arch: mips: kernel: using strlcpy() instead of strncpy() Chen Gang
2013-05-27 10:38 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A337B9.60402@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox