From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: davem@davemloft.net, ralf@linux-mips.org, blogic@openwrt.org,
linux-mips@linux-mips.org, cernekee@gmail.com, mbizon@freebox.fr,
jogo@openwrt.org
Subject: Re: [PATCH 1/3 net-next] bcm63xx_enet: implement reset autoneg ethtool callback
Date: Wed, 05 Jun 2013 01:49:42 +0400 [thread overview]
Message-ID: <51AE60F6.80101@cogentembedded.com> (raw)
In-Reply-To: <1370382094-17821-2-git-send-email-florian@openwrt.org>
Hello.
On 06/05/2013 01:41 AM, Florian Fainelli wrote:
Why are you not posting to netdev@vger.kernel.org?
> From: Maxime Bizon <mbizon@freebox.fr>
>
> Implement the rset_nway ethtool callback which uses libphy generic
> autonegotiation restart function.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> ---
> drivers/net/ethernet/broadcom/bcm63xx_enet.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index e46466c..bc1a994 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -1328,6 +1328,20 @@ static void bcm_enet_get_ethtool_stats(struct net_device *netdev,
> mutex_unlock(&priv->mib_update_lock);
> }
>
> +static int bcm_enet_nway_reset(struct net_device *dev)
> +{
> + struct bcm_enet_priv *priv;
> +
> + priv = netdev_priv(dev);
Strange, why not do it in the initializer?
WBR, Sergei
next prev parent reply other threads:[~2013-06-04 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 21:41 [PATCH 0/3 net-next] bcm63xx_enet: add support for BCM63xx gigabit integrated switch Florian Fainelli
2013-06-04 21:41 ` [PATCH 1/3 net-next] bcm63xx_enet: implement reset autoneg ethtool callback Florian Fainelli
2013-06-04 21:49 ` Sergei Shtylyov [this message]
2013-06-04 21:41 ` [PATCH 2/3 net-next] bcm63xx_enet: split DMA channel register accesses Florian Fainelli
2013-06-04 21:41 ` [PATCH 3/3 net-next] bcm63xx_enet: add support for Broadcom BCM63xx integrated gigabit switch Florian Fainelli
2013-06-10 21:28 ` [PATCH 0/3 net-next] bcm63xx_enet: add support for BCM63xx gigabit integrated switch David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-06-04 21:53 Florian Fainelli
2013-06-04 21:53 ` [PATCH 1/3 net-next] bcm63xx_enet: implement reset autoneg ethtool callback Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE60F6.80101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=blogic@openwrt.org \
--cc=cernekee@gmail.com \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox