From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org,
Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>,
ralf@linux-mips.org, Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET"
Date: Thu, 20 Jun 2013 15:09:51 +0400 [thread overview]
Message-ID: <51C2E2FF.9070703@cogentembedded.com> (raw)
In-Reply-To: <1371705218-4570-1-git-send-email-Steven.Hill@imgtec.com>
Hello.
On 20-06-2013 9:13, Steven J. Hill wrote:
> From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
> This reverts commit 3f4579252aa166641861a64f1c2883365ca126c2. It is
> invalid because the macros CAC_ADDR and UNCAC_ADDR have a kernel
> virtual address as an argument and also returns a kernel virtual
> address. Using and physical address PHYS_OFFSET is blatantly wrong
> for a macro common to multiple platforms.
> Change-Id: I19feb1e537c6a517e6b42f3ec6ce746b6a97617e
Same comment as on all Leonid's patches -- remove this line.
> Signed-off-by: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
WBR, Sergei
prev parent reply other threads:[~2013-06-20 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 5:13 [PATCH] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET" Steven J. Hill
2013-06-20 11:09 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C2E2FF.9070703@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox