From: David Daney <ddaney.cavm@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once
Date: Mon, 24 Jun 2013 15:33:36 -0700 [thread overview]
Message-ID: <51C8C940.7080106@gmail.com> (raw)
In-Reply-To: <20130624220429.GB20703@blackmetal.musicnaut.iki.fi>
On 06/24/2013 03:04 PM, Aaro Koskinen wrote:
> On Mon, Jun 24, 2013 at 11:52:23AM -0700, David Daney wrote:
>> On 06/23/2013 02:38 PM, Aaro Koskinen wrote:
>>> When booting a new board for the first time, the console is flooded with
>>> "Unknown board" messages. This is not really helpful. Board type is not
>>> going to change after the boot, so it's sufficient to print the warning
>>> only once.
>>>
>>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>>
>> I don't think we need this patch. In 2/2 you add the board type for
>> the board you have, so you shouldn't be getting any messages, and
>> this is unneeded.
>>
>> I don't mind spamming people with all the messages, if people see
>> these messages, they have bigger problems than too many messages.
>
> I guess this patch can be dropped, but whoever tries to improve the
> support for the next new Octeon board will get annoyed by these same
> messages...
I would hope that the "next new Octeon board" would have a bootloader
that supplies a device tree. That way most of this would never be used,
and there would be no messages.
David Daney
next prev parent reply other threads:[~2013-06-24 22:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 21:38 [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once Aaro Koskinen
2013-06-23 21:38 ` [PATCH v2 2/2] MIPS: cavium-octeon: enable interfaces on EdgeRouter Lite Aaro Koskinen
2013-06-24 18:48 ` David Daney
2013-06-28 21:41 ` Aaro Koskinen
2013-06-24 18:52 ` [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once David Daney
2013-06-24 22:04 ` Aaro Koskinen
2013-06-24 22:33 ` David Daney [this message]
2013-06-24 23:06 ` Aaro Koskinen
2013-06-24 23:24 ` David Daney
2013-06-26 18:47 ` Ralf Baechle
2013-06-28 22:58 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C8C940.7080106@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox