Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: bcm63xx: clk: Add dummy clk_set_rate() function
Date: Mon, 01 Jul 2013 13:06:02 +0200	[thread overview]
Message-ID: <51D1629A.6040700@metafoo.de> (raw)
In-Reply-To: <1372676244-1399-1-git-send-email-markos.chandras@imgtec.com>

On 07/01/2013 12:57 PM, Markos Chandras wrote:
> Several drivers use the clk_set_rate() function that needs
> to be defined in the platform's clock code. The Broadcom
> BCM63xx platform hardcodes the clock rate so we create a new
> dummy clk_set_rate() function which just returns -EINVAL.
> 
> Also fixes the following build problem on a randconfig:
> drivers/built-in.o: In function `nop_usb_xceiv_probe':
> phy-nop.c:(.text+0x3ec26c): undefined reference to `clk_set_rate'
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com> 

To make the set complete clk_round_rate() should be added as well

> ---
> This patch is for the upstream-sfr/mips-for-linux-next tree
> ---
>  arch/mips/bcm63xx/clk.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
> index c726a97..70dcc52 100644
> --- a/arch/mips/bcm63xx/clk.c
> +++ b/arch/mips/bcm63xx/clk.c
> @@ -318,6 +318,12 @@ unsigned long clk_get_rate(struct clk *clk)
>  
>  EXPORT_SYMBOL(clk_get_rate);
>  
> +int clk_set_rate(struct clk *clk, unsigned long rate)
> +{
> +	return -EINVAL;
> +}
> +EXPORT_SYMBOL_GPL(clk_set_rate);
> +
>  struct clk *clk_get(struct device *dev, const char *id)
>  {
>  	if (!strcmp(id, "enet0"))

  parent reply	other threads:[~2013-07-01 11:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 10:57 [PATCH] MIPS: bcm63xx: clk: Add dummy clk_set_rate() function Markos Chandras
2013-07-01 10:57 ` Markos Chandras
2013-07-01 11:06 ` Lars-Peter Clausen [this message]
2013-07-01 13:06   ` Markos Chandras
2013-07-01 13:06     ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D1629A.6040700@metafoo.de \
    --to=lars@metafoo.de \
    --cc=linux-mips@linux-mips.org \
    --cc=markos.chandras@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox