Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>, Ralf Baechle <ralf@linux-mips.org>
Cc: Jayachandran C <jchandra@broadcom.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1
Date: Thu, 18 Jul 2013 10:19:51 -0700	[thread overview]
Message-ID: <51E823B7.6040200@gmail.com> (raw)
In-Reply-To: <1373876517-14646-1-git-send-email-aaro.koskinen@iki.fi>

On 07/15/2013 01:21 AM, Aaro Koskinen wrote:
> Commit 6ba045f9fbdafb48da42aa8576ea7a3980443136 (MIPS: Move generated code
> to .text for microMIPS) deleted tlbmiss_handler_setup_pgd_array, but some
> references were not converted. Fix that to enable building a MIPS kernel.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

Yes, this appears to be needed.

Acked-by: David Daney <david.daney@cavium.com>


> ---
>   arch/mips/mm/tlbex.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 9ab0f90..cc34521 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -1466,7 +1466,7 @@ static void __cpuinit build_r4000_setup_pgd(void)
>   {
>   	const int a0 = 4;
>   	const int a1 = 5;
> -	u32 *p = tlbmiss_handler_setup_pgd_array;
> +	u32 *p = tlbmiss_handler_setup_pgd;
>   	const int tlbmiss_handler_setup_pgd_size =
>   		tlbmiss_handler_setup_pgd_end - tlbmiss_handler_setup_pgd;
>   	struct uasm_label *l = labels;
>

      parent reply	other threads:[~2013-07-18 17:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15  8:21 [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1 Aaro Koskinen
2013-07-15  9:55 ` Jayachandran C.
2013-07-18 17:19 ` David Daney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E823B7.6040200@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=jchandra@broadcom.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox