From: John Crispin <john@phrozen.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Gabor Juhos <juhosg@openwrt.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 6/6] MIPS: ath79: simplify platform_get_resource_byname/devm_ioremap_resource
Date: Sat, 31 Aug 2013 10:09:37 +0200 [thread overview]
Message-ID: <5221A4C1.90703@phrozen.org> (raw)
In-Reply-To: <52164F54.2070209@openwrt.org>
On 22/08/13 19:50, Gabor Juhos wrote:
> 2013.08.19. 10:51 keltezéssel, Julia Lawall írta:
>> From: Julia Lawall<Julia.Lawall@lip6.fr>
>>
>> Remove unneeded error handling on the result of a call to
>> platform_get_resource_byname when the value is passed to devm_ioremap_resource.
>>
>> A simplified version of the semantic patch that makes this change is as
>> follows: (http://coccinelle.lip6.fr/)
>>
>> //<smpl>
>> @@
>> expression pdev,res,e,e1;
>> expression ret != 0;
>> identifier l;
>> @@
>>
>> res = platform_get_resource_byname(...);
>> - if (res == NULL) { ... \(goto l;\|return ret;\) }
>> e = devm_ioremap_resource(e1, res);
>> //</smpl>
>>
>> Signed-off-by: Julia Lawall<Julia.Lawall@lip6.fr>
>
> Acked-by: Gabor Juhos<juhosg@openwrt.org>
>
> Thanks!
>
> -Gabor
Hi,
should this patch go upstream via the lmo tree ?
John
next prev parent reply other threads:[~2013-08-31 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 8:51 [PATCH 0/6] simplify platform_get_resource_byname/devm_ioremap_resource Julia Lawall
2013-08-19 8:51 ` [PATCH 6/6] MIPS: ath79: " Julia Lawall
2013-08-22 17:50 ` Gabor Juhos
2013-08-31 8:09 ` John Crispin [this message]
2013-08-31 9:41 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5221A4C1.90703@phrozen.org \
--to=john@phrozen.org \
--cc=Julia.Lawall@lip6.fr \
--cc=juhosg@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox