Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: powertv: Drop BOOTLOADER_DRIVER Kconfig symbol
Date: Sun, 01 Sep 2013 19:42:14 +0200	[thread overview]
Message-ID: <52237C76.4010608@phrozen.org> (raw)
In-Reply-To: <1377075213-22398-1-git-send-email-markos.chandras@imgtec.com>

On 21/08/13 10:53, Markos Chandras wrote:
> The kbldr.h header file required for this was neither committed in the
> original submission in a3a0f8c8ed2e2470f4dcd6da95020d41fed84747
> "MIPS: PowerTV: Base files for Cisco PowerTV platform"
> nor it was ever present in the git tree so this option never worked.
> Fixes the following build problem:
> arch/mips/powertv/reset.c:25:36: fatal error: asm/mach-powertv/kbldr.h: No such
> file or directory
> compilation terminated.
>
> Signed-off-by: Markos Chandras<markos.chandras@imgtec.com>
> Acked-by: Steven J. Hill<Steven.Hill@imgtec.com>
> ---
> This patch is for the upstream-sfr/mips-for-linux-next tree
> ---
>   arch/mips/Kconfig                     |  1 +
>   arch/mips/powertv/Kconfig             |  9 +--------
>   arch/mips/powertv/asic/asic_devices.c | 15 +++------------
>   arch/mips/powertv/init.c              |  4 ----
>   arch/mips/powertv/reset.c             | 12 ------------
>   5 files changed, 5 insertions(+), 36 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index e12764c..d08a3a6 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -416,6 +416,7 @@ config PMC_MSP
>   config POWERTV
>   	bool "Cisco PowerTV"
>   	select BOOT_ELF32
> +	select BOOTLOADER_FAMILY
>   	select CEVT_R4K
>   	select CPU_MIPSR2_IRQ_VI
>   	select CPU_MIPSR2_IRQ_EI

Hi,

BOOTLOADER_FAMILY is a string causing the select to spew this error

-> arch/mips/Kconfig:420:warning: 'BOOTLOADER_FAMILY' has wrong type. 
'select' only accept arguments of boolean and tristate type

	John

  parent reply	other threads:[~2013-09-01 17:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  8:53 [PATCH] MIPS: powertv: Drop BOOTLOADER_DRIVER Kconfig symbol Markos Chandras
2013-08-21  8:53 ` Markos Chandras
2013-09-01 17:42 ` John Crispin [this message]
2013-09-02 10:11   ` Markos Chandras
2013-09-02 10:11     ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52237C76.4010608@phrozen.org \
    --to=john@phrozen.org \
    --cc=linux-mips@linux-mips.org \
    --cc=markos.chandras@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox