From: Gabor Juhos <juhosg@openwrt.org>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig
Date: Sun, 01 Sep 2013 20:44:24 +0200 [thread overview]
Message-ID: <52238B08.3020408@openwrt.org> (raw)
In-Reply-To: <1378057127-21984-1-git-send-email-blogic@openwrt.org>
2013.09.01. 19:38 keltezéssel, John Crispin írta:
> Without this symbol being set, we get an undefined symbol compile error.
The reset framework is unconditionally used by the ralink platform code. So I
assume that the compile error is also present on rt288x, rt3883 and mt7620.
Maybe it would be better to add a 'select RESET_CONTROLLER' for the RALINK
symbol in 'arch/mips/Kconfig'?
BTW, I have looked into your 'MIPS: ralink: add support for reset-controller
API' patch [1] again. That adds a 'select ARCH_HAS_RESET_CONTROLLER' to the
MACH_VR41XX symbol instead of RALINK.
-Gabor
1. https://patchwork.linux-mips.org/patch/5668/
next prev parent reply other threads:[~2013-09-01 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 17:38 [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig John Crispin
2013-09-01 18:44 ` Gabor Juhos [this message]
2013-09-01 18:48 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52238B08.3020408@openwrt.org \
--to=juhosg@openwrt.org \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox