From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 18 Sep 2013 13:29:25 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:48764 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6824104Ab3IRL3VufV3Z (ORCPT ); Wed, 18 Sep 2013 13:29:21 +0200 Message-ID: <52398E51.6050306@imgtec.com> Date: Wed, 18 Sep 2013 12:28:17 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Ralf Baechle CC: Subject: Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well References: <1378460846-961-1-git-send-email-markos.chandras@imgtec.com> <20130918111053.GK22468@linux-mips.org> In-Reply-To: <20130918111053.GK22468@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.31] X-SEF-Processed: 7_3_0_01192__2013_09_18_12_29_16 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37843 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 09/18/13 12:10, Ralf Baechle wrote: > On Fri, Sep 06, 2013 at 10:47:26AM +0100, Markos Chandras wrote: > >> The CMP code is only designed to work with SMP configurations. >> Fixes multiple build problems on certain randconfigs: > > Applied - but I think the logic here may be backwards from a user's > perspective. Shouldn't a user be asked for SMP first, then for > possible platform suboptions (CMP, VSMP, SMTC) of SMP? > > Ralf > Hi Ralf, Well, for example, you can have VSMP with or without CMP so CMP is not another SMP option but rather an "add-on". However, it might be preferred to move the SMP option higher in the menu. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:48764 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6824104Ab3IRL3VufV3Z (ORCPT ); Wed, 18 Sep 2013 13:29:21 +0200 Message-ID: <52398E51.6050306@imgtec.com> Date: Wed, 18 Sep 2013 12:28:17 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well References: <1378460846-961-1-git-send-email-markos.chandras@imgtec.com> <20130918111053.GK22468@linux-mips.org> In-Reply-To: <20130918111053.GK22468@linux-mips.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Ralf Baechle Cc: linux-mips@linux-mips.org Message-ID: <20130918112817.T3WNymu16aNOhbYJXSL5jIdd5-KBFHd3E6gZ79dSl9w@z> On 09/18/13 12:10, Ralf Baechle wrote: > On Fri, Sep 06, 2013 at 10:47:26AM +0100, Markos Chandras wrote: > >> The CMP code is only designed to work with SMP configurations. >> Fixes multiple build problems on certain randconfigs: > > Applied - but I think the logic here may be backwards from a user's > perspective. Shouldn't a user be asked for SMP first, then for > possible platform suboptions (CMP, VSMP, SMTC) of SMP? > > Ralf > Hi Ralf, Well, for example, you can have VSMP with or without CMP so CMP is not another SMP option but rather an "add-on". However, it might be preferred to move the SMP option higher in the menu.