From: John Crispin <blogic@openwrt.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: ralf@linux-mips.org, grant.likely@linaro.org,
rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: ralink: fix return value check in rt_timer_probe()
Date: Thu, 31 Oct 2013 10:52:17 +0100 [thread overview]
Message-ID: <52722851.30302@openwrt.org> (raw)
In-Reply-To: <CAPgLHd81Ucjnc=pmdxiZzBrk15ui1ezyowdd8JxYzvmmdLoMwQ@mail.gmail.com>
On 31/10/13 08:51, Wei Yongjun wrote:
> From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_request_and_ioremap() returns NULL
> pointer not ERR_PTR(). Fix it by using devm_ioremap_resource() instead
> of devm_request_and_ioremap().
>
> Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
Thanks for spotting the bug.
Acked-by: John Crispin <blogic@openwrt.org>
prev parent reply other threads:[~2013-10-31 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 7:51 [PATCH] MIPS: ralink: fix return value check in rt_timer_probe() Wei Yongjun
2013-10-31 9:52 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52722851.30302@openwrt.org \
--to=blogic@openwrt.org \
--cc=grant.likely@linaro.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rob.herring@calxeda.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox