From: David Daney <ddaney.cavm@gmail.com>
To: Aaro Koskinen <aaro.koskinen@nsn.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: David Daney <david.daney@cavium.com>,
linux-mips@linux-mips.org, Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH v2 1/2] MIPS: cavium-octeon: fix out-of-bounds array access
Date: Fri, 08 Nov 2013 13:45:05 -0800 [thread overview]
Message-ID: <527D5B61.7090105@gmail.com> (raw)
In-Reply-To: <1383318364-30312-1-git-send-email-aaro.koskinen@nsn.com>
On 11/01/2013 08:06 AM, Aaro Koskinen wrote:
> When booting with in-kernel DTBs, the pruning code will enumerate
> interfaces 0-4. However, there is memory reserved only for 4 so some
> other data will get overwritten by cvmx_helper_interface_enumerate().
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
Thanks for finding this, tested and ...
Acked-by: David Daney <david.daney@cavium.com>
Ralf: Please apply.
Aaro: Suggest stable branches that this is a candidate for.
> ---
>
> v2: a new patch in the series
>
> arch/mips/cavium-octeon/executive/cvmx-helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/cavium-octeon/executive/cvmx-helper.c
> index d63d20d..0e4b340 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper.c
> @@ -67,7 +67,7 @@ void (*cvmx_override_pko_queue_priority) (int pko_port,
> void (*cvmx_override_ipd_port_setup) (int ipd_port);
>
> /* Port count per interface */
> -static int interface_port_count[4] = { 0, 0, 0, 0 };
> +static int interface_port_count[5];
>
> /* Port last configured link info index by IPD/PKO port */
> static cvmx_helper_link_info_t
>
next prev parent reply other threads:[~2013-11-08 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 15:06 [PATCH v2 1/2] MIPS: cavium-octeon: fix out-of-bounds array access Aaro Koskinen
2013-11-01 15:06 ` [PATCH v2 2/2] MIPS: cavium-octeon: fix early boot hang on EBH5600 board Aaro Koskinen
2013-11-08 21:46 ` David Daney
2013-11-08 21:45 ` David Daney [this message]
2013-11-08 23:27 ` [PATCH v2 1/2] MIPS: cavium-octeon: fix out-of-bounds array access Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527D5B61.7090105@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=aaro.koskinen@nsn.com \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox