From: Shinya Kuribayashi <skuribay@pobox.com>
To: ralf@linux-mips.org, jbaron@akamai.com
Cc: mingo@kernel.org, benh@kernel.crashing.org, paulus@samba.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, florian@openwrt.org,
jchandra@broadcom.com, ganesanr@broadcom.com
Subject: Re: [PATCH v2] panic: Make panic_timeout configurable
Date: Tue, 19 Nov 2013 23:51:27 +0900 [thread overview]
Message-ID: <528B7AEF.7020805@pobox.com> (raw)
In-Reply-To: <20131119090211.GN10382@linux-mips.org>
On 11/19/13 6:02 PM, Ralf Baechle wrote:> On Mon, Nov 18, 2013 at 09:04:36PM +0000, Jason Baron wrote:
> It's more complicated - MIPS was using the global default with five MIPS
> platforms overriding the default.
>
> I propose to kill these overrides for sanity unless somebody comes up
> with a good argument. Patch below.
>
> Ralf
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> arch/mips/ar7/setup.c | 1 -
> arch/mips/emma/markeins/setup.c | 3 ---
> arch/mips/netlogic/xlp/setup.c | 1 -
> arch/mips/netlogic/xlr/setup.c | 1 -
> arch/mips/sibyte/swarm/setup.c | 2 --
> 5 files changed, 8 deletions(-)
[...]
> diff --git a/arch/mips/emma/markeins/setup.c b/arch/mips/emma/markeins/setup.c
> index d710058..9100122 100644
> --- a/arch/mips/emma/markeins/setup.c
> +++ b/arch/mips/emma/markeins/setup.c
> @@ -111,9 +111,6 @@ void __init plat_mem_setup(void)
> iomem_resource.start = EMMA2RH_IO_BASE;
> iomem_resource.end = EMMA2RH_ROM_BASE - 1;
>
> - /* Reboot on panic */
> - panic_timeout = 180;
> -
> markeins_sio_setup();
> }
>
IIRC we had set it to 180 seconds for some historical reasons, but
I'm afraid nobody can recall the reason why it's set so in 2013...
Anyway I was thinking it too long and reduced to a few seconds locally
when debugging, so there shouldn't be a problem with this change.
FWIW, for EMMA2RH portion:
Acked-by: Shinya Kuribayashi <skuribay@pobox.com>
Thank you always for your help, Ralf.
next prev parent reply other threads:[~2013-11-19 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131118210436.233B5202A@prod-mail-relay06.akamai.com>
2013-11-19 9:02 ` [PATCH v2] panic: Make panic_timeout configurable Ralf Baechle
2013-11-19 14:51 ` Shinya Kuribayashi [this message]
2013-11-19 16:38 ` Ralf Baechle
2013-11-19 17:11 ` Jason Baron
2013-11-19 17:22 ` Ralf Baechle
2013-11-21 8:44 ` Jayachandran C.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B7AEF.7020805@pobox.com \
--to=skuribay@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=florian@openwrt.org \
--cc=ganesanr@broadcom.com \
--cc=jbaron@akamai.com \
--cc=jchandra@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox