Re: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h

[David Daney <ddaney.cavm@gmail.com>]

On 12/09/2013 01:49 AM, Qais Yousef wrote:
> The file uses u16 type but doesn't include its definition explicitly
>
> I was getting this error when including this header in my driver:
>
>    arch/mips/include/asm/mipsregs.h:644:33: error: unknown type name ‘u16’
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>

Acked-by: David Daney <david.daney@cavium.com>

> ---
> changes since v1:
> 	- include linux/types.h instead of s/u16/unsigned short/
> 	- amend commit message accordingly
>
>   arch/mips/include/asm/mipsregs.h |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h
> index e033141..86479bb 100644
> --- a/arch/mips/include/asm/mipsregs.h
> +++ b/arch/mips/include/asm/mipsregs.h
> @@ -14,6 +14,7 @@
>   #define _ASM_MIPSREGS_H
>
>   #include <linux/linkage.h>
> +#include <linux/types.h>
>   #include <asm/hazards.h>
>   #include <asm/war.h>
>
>