From: David Daney <ddaney.cavm@gmail.com>
To: Christoph Lameter <cl@linux.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Cc: Tejun Heo <tj@kernel.org>,
akpm@linuxfoundation.org, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 29/40] mips: Replace __get_cpu_var uses
Date: Thu, 19 Dec 2013 15:08:06 -0800 [thread overview]
Message-ID: <52B37C56.7090302@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1312191506370.17603@nuc>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On 12/19/2013 01:10 PM, Christoph Lameter wrote:
> On Thu, 19 Dec 2013, David Daney wrote:
>
>>> 16:07:58.244398747 -0600
>>> @@ -43,7 +43,7 @@ DECLARE_PER_CPU(struct mips_fpu_emulator
>>> #define MIPS_FPU_EMU_INC_STATS(M) \
>>> do {
>>> \
>>> preempt_disable(); \
>>> - __local_inc(&__get_cpu_var(fpuemustats).M); \
>>> + __this_cpu_inc(fpuemustats.M); \
>>> preempt_enable(); \
>>> } while (0)
>>>
>>
>> Something seems to be incorrect in this bit.
>
> Hrmm.. yes this is a local_t so the this_cpu_inc would not work unless
> fpuemustats is defined differently.
>
See the attached patch. Feel free to include it as part of your patch set.
I tested it on a 64-bit OCTEON system. I think it will work on 32-bit
systems as well.
> Use
>
> __local_inc(this_cpu_ptr(fpuemustats.M);
>
No, I couldn't get various incantations of that to work either.
> instead until then.
>
next parent reply other threads:[~2013-12-19 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131219155015.443763038@linux.com>
[not found] ` <20131219155033.834416420@linux.com>
[not found] ` <52B330F3.4090603@gmail.com>
[not found] ` <alpine.DEB.2.10.1312191506370.17603@nuc>
2013-12-19 23:08 ` David Daney [this message]
2013-12-20 17:43 ` [PATCH 29/40] mips: Replace __get_cpu_var uses Christoph Lameter
2013-12-20 17:43 ` Christoph Lameter
2013-12-20 17:49 ` Christoph Lameter
2013-12-20 17:49 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B37C56.7090302@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox