Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin
Date: Fri, 14 Mar 2014 22:30:42 +0100	[thread overview]
Message-ID: <53237502.20305@hauke-m.de> (raw)
In-Reply-To: <1392310092-27365-1-git-send-email-zajec5@gmail.com>

On 02/13/2014 05:48 PM, Rafał Miłecki wrote:
> Broadcom boards support 32 GPIOs and NVRAM may have entires for higher
> ones too. Example:
> gpio23=wombo_reset
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>

Acked-by: Hauke Mehrtens <hauke@hauke-m.de>

> ---
> Preferably this should go as a fix for 3.14. It's really trivial and
> allows support for some devices that require reset by GPIO after boot.
> ---
>  arch/mips/bcm47xx/nvram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/bcm47xx/nvram.c b/arch/mips/bcm47xx/nvram.c
> index 6decb27..2bed73a 100644
> --- a/arch/mips/bcm47xx/nvram.c
> +++ b/arch/mips/bcm47xx/nvram.c
> @@ -196,7 +196,7 @@ int bcm47xx_nvram_gpio_pin(const char *name)
>  	char nvram_var[10];
>  	char buf[30];
>  
> -	for (i = 0; i < 16; i++) {
> +	for (i = 0; i < 32; i++) {
>  		err = snprintf(nvram_var, sizeof(nvram_var), "gpio%i", i);
>  		if (err <= 0)
>  			continue;
> 

  parent reply	other threads:[~2014-03-14 21:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 16:48 [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin Rafał Miłecki
2014-02-28  6:27 ` Rafał Miłecki
2014-03-13 15:22   ` Rafał Miłecki
2014-03-14 21:30 ` Hauke Mehrtens [this message]
2014-03-19  6:43   ` Rafał Miłecki
2014-03-19  8:47     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53237502.20305@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox