Re: [PATCH 3/3] MIPS: Alchemy: pata_platform for DB1200

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 26-03-2014 13:41, Manuel Lauss wrote:

> The au1xxx-ide driver isn't any faster than pata_platform since it
> spends a lot of time busy waiting for DMA to finish; faster PIO/DMA
> modes only work on the db1200 with a certain cpu speed, UDMA is broken
> and finally the old IDE layer is on death row, so time to switch to
> the winning side.

> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
>   arch/mips/alchemy/devboards/db1200.c | 18 +++++++++++++++---
>   arch/mips/configs/db1xxx_defconfig   |  3 ---
>   2 files changed, 15 insertions(+), 6 deletions(-)

> diff --git a/arch/mips/alchemy/devboards/db1200.c b/arch/mips/alchemy/devboards/db1200.c
> index 4bcf2f4..40fa3a6 100644
> --- a/arch/mips/alchemy/devboards/db1200.c
> +++ b/arch/mips/alchemy/devboards/db1200.c
[...]
> @@ -330,6 +331,11 @@ static struct platform_device db1200_eth_dev = {
>
>   /**********************************************************************/
>
> +static struct pata_platform_info db1200_ide_info = {
> +	.ioport_shift	= DB1200_IDE_REG_SHIFT,
> +};
> +
> +#define IDE_ALT_START	(14 << DB1200_IDE_REG_SHIFT)
>   static struct resource db1200_ide_res[] = {
>   	[0] = {
>   		.start	= DB1200_IDE_PHYS_ADDR,
> @@ -337,25 +343,31 @@ static struct resource db1200_ide_res[] = {
>   		.flags	= IORESOURCE_MEM,
>   	},
>   	[1] = {
> +		.start	= DB1200_IDE_PHYS_ADDR + IDE_ALT_START,
> +		.end	= DB1200_IDE_PHYS_ADDR + DB1200_IDE_PHYS_LEN - 1,

    This now intersects with resource 0.

> +		.flags	= IORESOURCE_MEM,
> +	},
> +	[2] = {
>   		.start	= DB1200_IDE_INT,
>   		.end	= DB1200_IDE_INT,
>   		.flags	= IORESOURCE_IRQ,
>   	},
> -	[2] = {
> +/*	[3] = {
>   		.start	= AU1200_DSCR_CMD0_DMA_REQ1,
>   		.end	= AU1200_DSCR_CMD0_DMA_REQ1,
>   		.flags	= IORESOURCE_DMA,
> -	},
> +	},*/
>   };

    Commented out code is not allowed, just remove it please.

WBR, Sergei