From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jayachandran C <jchandra@broadcom.com>, linux-mips@linux-mips.org
Cc: ralf@linux-mips.org
Subject: Re: [PATCH 11/17] MIPS: Netlogic: Fix XLP9XX pic entry
Date: Tue, 29 Apr 2014 21:36:18 +0400 [thread overview]
Message-ID: <535FE312.50400@cogentembedded.com> (raw)
In-Reply-To: <db9d6d674a9fadeb7bad499ade3d66cc715fb6dd.1398780013.git.jchandra@broadcom.com>
Hello.
On 04/29/2014 06:37 PM, Jayachandran C wrote:
> Add the compatible property to the PIC entry. Also fix up the nodename
> to use the correct address.
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
> arch/mips/netlogic/dts/xlp_gvp.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> diff --git a/arch/mips/netlogic/dts/xlp_gvp.dts b/arch/mips/netlogic/dts/xlp_gvp.dts
> index 047d27f..bb4ecd1 100644
> --- a/arch/mips/netlogic/dts/xlp_gvp.dts
> +++ b/arch/mips/netlogic/dts/xlp_gvp.dts
> @@ -26,11 +26,12 @@
> interrupt-parent = <&pic>;
> interrupts = <17>;
> };
> - pic: pic@4000 {
> - interrupt-controller;
> + pic: pic@110000 {
According to the ePAPR standard [1], the node name should be
"interrupt-controller@110000".
> + compatible = "netlogic,xlp-pic";
> #address-cells = <0>;
> #interrupt-cells = <1>;
> reg = <0 0x110000 0x200>;
> + interrupt-controller;
> };
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
next prev parent reply other threads:[~2014-04-29 17:36 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 14:37 [PATCH 00/17] Broadcom XLP changes for 3.16 Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 01/17] MIPS: Support upto 256 CPUs Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 02/17] MIPS: Netlogic: Fix uniprocessor compilation Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 03/17] MIPS: Netlogic: Move coremask setup to nlm_node_init Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 04/17] MIPS: Netlogic: Warn on invalid irq Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 05/17] MIPS: Netlogic: Update function to read DRAM BARs Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 06/17] MIPS: Netlogic: Use cpumask_scnprintf for wakup_mask Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-05-09 11:04 ` [PATCH v2 06/17] MIPS: Netlogic: Use cpumask_scnprintf for wakeup_mask Jayachandran C
2014-05-09 11:04 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 07/17] MIPS: Netlogic: Reduce size of reset code Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-05-09 11:05 ` [PATCH v2 " Jayachandran C
2014-05-09 11:05 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 08/17] MIPS: Netlogic: Enable access to more than 64GB Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 09/17] MIPS: Netlogic: IRQ mapping for some more SoC blocks Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-05-09 11:05 ` [PATCH v2 " Jayachandran C
2014-05-09 11:05 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 10/17] MIPS: Netlogic: Use PRID_IMP_MASK macro Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 11/17] MIPS: Netlogic: Fix XLP9XX pic entry Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 17:36 ` Sergei Shtylyov [this message]
2014-04-30 9:56 ` Jayachandran C.
2014-04-30 9:56 ` Jayachandran C.
2014-04-29 14:37 ` [PATCH 12/17] MIPS: Netlogic: PIC freq calculation for XLP 9XX/2XX Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 13/17] MIPS: Netlogic: Update XLP9XX/2XX core freq calculation Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 14/17] MIPS: Netlogic: Add support for XLP5XX Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 15/17] MIPS: Add MSI support for XLP9XX Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-05-09 11:05 ` [PATCH v2 " Jayachandran C
2014-05-09 11:05 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 16/17] MIPS: Netlogic: Support for XLP3XX on-chip SATA Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-04-29 14:37 ` [PATCH 17/17] MIPS: Netlogic: XLP9XX on-chip SATA support Jayachandran C
2014-04-29 14:37 ` Jayachandran C
2014-05-09 11:06 ` [PATCH v2 " Jayachandran C
2014-05-09 11:06 ` Jayachandran C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535FE312.50400@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jchandra@broadcom.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox