From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62ADCC433F5 for ; Sat, 9 Apr 2022 13:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241921AbiDINRp (ORCPT ); Sat, 9 Apr 2022 09:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241916AbiDINRn (ORCPT ); Sat, 9 Apr 2022 09:17:43 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17BCC70908 for ; Sat, 9 Apr 2022 06:15:35 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id k23so22281597ejd.3 for ; Sat, 09 Apr 2022 06:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=S1kx45CDYtbXE3aPQS22yI8qdr+jqfxleCsscPsVroo=; b=l4QBV0ALsMCa7V6Qgs7OAKmW6ZvX8tgBkP3b+1vA5GnBkykASR3TEFGnl7wTNqZOeE JyuPUeRxjDlnXG7M8z9lzjzvWVMrM94/fxYwAr1RFL5yRelqr7Ufnw8jtFHKAznJLDvH kFInQ7n6yic+bRw0MSOlHSYgyOnglXuV5D2t8SCvayqETm6YvPfzVBqc42rRL8sFP3YH jCn8+DNZ+KHwsRuH0mgVhe4kY63vRODpdoBO0PzSldVRY78Kn/oZDgrfJ/i/elz+HQTj wZI2wbY73wxdvgor/4ND3PlNtepqdQkcH362r9f1hh9qpLFUTNu95LQbFgyFkSOcUUSm SCOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=S1kx45CDYtbXE3aPQS22yI8qdr+jqfxleCsscPsVroo=; b=4fzMo8RN7Ga28jawGJWcKP6S0l2/3ZFDfPy2SyzsNtr4crn+EoK/NHcKqDP58Vr2vz hLddK3IYCt0tU1haL/TsuON7LKuX3N2WI6/YjHRvIYx//KA1ghwyx66TbR2pZFSQksa/ pQ6BVMNyEVN17o6RpLGWXuYvvcAwbUATgUntupGjhWTGtNaedW1iS9QuliFPf91+FEf0 O8FUaX/NpB25F93GSuft/SZDxm+SVsaO/g1OOW8Jo6KUMMZ45IskQB4LDDiVxD7olexz qRuWQF5YjUykwZBYvWcWftIcTI3kKdsuw7tW+A60K+Pk6/LaUDf56RLP47AY7m8MpTCx Rttw== X-Gm-Message-State: AOAM530xJ3jpLIDsS4KNwfpcdifutIq/zO6+YpWAmgwPhGQdBRmXRn9s +rHgt0a0F06W6wuaIhQ7qcNRrA== X-Google-Smtp-Source: ABdhPJyhcWkx5nvbgdb9aN9/K78uAs1TAb9srjwlo+4FYaMTNGRjKYmU9qZumuKsjZpCKJkPNNjdrA== X-Received: by 2002:a17:906:7952:b0:6da:94c9:cccb with SMTP id l18-20020a170906795200b006da94c9cccbmr22644777ejo.469.1649510133702; Sat, 09 Apr 2022 06:15:33 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id mp19-20020a1709071b1300b006dfdfe15cf8sm9940447ejc.196.2022.04.09.06.15.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 06:15:33 -0700 (PDT) Message-ID: <535e3eab-a28e-46f3-2a7e-f1ffd1913470@linaro.org> Date: Sat, 9 Apr 2022 15:15:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by dtbscheck Content-Language: en-US To: "H. Nikolaus Schaller" Cc: Rob Herring , Paul Cercueil , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org References: <298162bfa2e7225ccc753865e1ffa39ce2722b2a.1649443080.git.hns@goldelico.com> <822182F3-5429-4731-9FA1-8F18C5D95DEC@goldelico.com> From: Krzysztof Kozlowski In-Reply-To: <822182F3-5429-4731-9FA1-8F18C5D95DEC@goldelico.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 09/04/2022 15:05, H. Nikolaus Schaller wrote: >> >> This looks wrong, the block usually should have a specific compatible. >> Please mention why it does not. > > Well, I did not even have that idea that it could need an explanation. > > There is no "ingenic,jz4780-otg" and none is needed here to make it work. Make it work in what terms? We talk about hardware description, right? > > Therefore the generic "snps,dwc2" is sufficient. No, you are mixing now driver behavior (is sufficient) with hardware description. Most of licensed blocks require the specific compatible to differentiate it. Best regards, Krzysztof