From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Liu Peibao <liupeibao@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Jianmin Lv <lvjianmin@loongson.cn>
Cc: Yinbo Zhu <zhuyinbo@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: loongson-liointc: fix improper error handling in liointc_init()
Date: Fri, 4 Nov 2022 12:48:40 +0300 [thread overview]
Message-ID: <539b63ee-7655-50c1-a95f-9f8210e7229d@gmail.com> (raw)
In-Reply-To: <20221104080347.21527-1-liupeibao@loongson.cn>
Hello!
On 11/4/22 11:03 AM, Liu Peibao wrote:
> For cores less than 4, eg, loongson2k1000 with 2 cores, the
> of_property_match_string() may return with an error value,
> which causes that liointc could not work. At least one isr
> is what should be checked like previous commit <b2c4c3969fd7>
> (irqchip/loongson-liointc: irqchip add 2.0 version) did.
It should look like this:
commit b2c4c3969fd7 ("irqchip/loongson-liointc: irqchip add 2.0 version")
> Fixes: 0858ed035a85 ("irqchip/loongson-liointc: Add ACPI init support")
> Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-11-04 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 8:03 [PATCH] irqchip: loongson-liointc: fix improper error handling in liointc_init() Liu Peibao
2022-11-04 9:48 ` Sergei Shtylyov [this message]
2022-11-04 10:59 ` Liu Peibao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539b63ee-7655-50c1-a95f-9f8210e7229d@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=lvjianmin@loongson.cn \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox