From: David Daney <ddaney.cavm@gmail.com>
To: Christoph Lameter <cl@linux.com>, linux-mips <linux-mips@linux-mips.org>
Cc: Tejun Heo <tj@kernel.org>,
akpm@linuxfoundation.org, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 19/31] MIPS: Replace __get_cpu_var uses in FPU emulator.
Date: Fri, 20 Jun 2014 13:07:36 -0700 [thread overview]
Message-ID: <53A49488.6050902@gmail.com> (raw)
In-Reply-To: <20140620193127.123705312@linux.com>
+ linux-mips@linux-mips.org, as that is the main MIPS patch reviewing list.
On 06/20/2014 12:31 PM, Christoph Lameter wrote:
> From: David Daney<david.daney@cavium.com>
>
> The use of __this_cpu_inc() requires a fundamental integer type, so
> change the type of all the counters to unsigned long, which is the
> same width they were before, but not wrapped in local_t.
>
> Signed-off-by: David Daney<david.daney@cavium.com>
> Signed-off-by: Christoph Lameter<cl@linux.com>
> ---
> arch/mips/include/asm/fpu_emulator.h | 14 +++++++-------
> arch/mips/math-emu/cp1emu.c | 6 +++---
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> Index: linux/arch/mips/include/asm/fpu_emulator.h
> ===================================================================
> --- linux.orig/arch/mips/include/asm/fpu_emulator.h 2014-06-16 09:15:42.199326017 -0500
> +++ linux/arch/mips/include/asm/fpu_emulator.h 2014-06-16 09:17:42.776959733 -0500
> @@ -33,17 +33,17 @@
> #ifdef CONFIG_DEBUG_FS
>
> struct mips_fpu_emulator_stats {
> - local_t emulated;
> - local_t loads;
> - local_t stores;
> - local_t cp1ops;
> - local_t cp1xops;
> - local_t errors;
> - local_t ieee754_inexact;
> - local_t ieee754_underflow;
> - local_t ieee754_overflow;
> - local_t ieee754_zerodiv;
> - local_t ieee754_invalidop;
> + unsigned long emulated;
> + unsigned long loads;
> + unsigned long stores;
> + unsigned long cp1ops;
> + unsigned long cp1xops;
> + unsigned long errors;
> + unsigned long ieee754_inexact;
> + unsigned long ieee754_underflow;
> + unsigned long ieee754_overflow;
> + unsigned long ieee754_zerodiv;
> + unsigned long ieee754_invalidop;
> };
>
> DECLARE_PER_CPU(struct mips_fpu_emulator_stats, fpuemustats);
> @@ -51,7 +51,7 @@
> #define MIPS_FPU_EMU_INC_STATS(M) \
> do { \
> preempt_disable(); \
> - __local_inc(&__get_cpu_var(fpuemustats).M); \
> + __this_cpu_inc(fpuemustats.M); \
> preempt_enable(); \
> } while (0)
>
>
parent reply other threads:[~2014-06-20 20:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20140620193127.123705312@linux.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A49488.6050902@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=cl@linux.com \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox