From: Paolo Bonzini <pbonzini@redhat.com>
To: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Cc: gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com,
james.hogan@imgtec.com, ralf@linux-mips.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH v3 0/9] MIPS: KVM: Bugfixes and cleanups
Date: Wed, 25 Jun 2014 14:18:26 +0200 [thread overview]
Message-ID: <53AABE12.5080001@redhat.com> (raw)
In-Reply-To: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com>
Il 24/06/2014 19:31, Deng-Cheng Zhu ha scritto:
> The patches are pretty straightforward.
>
> Changes:
> v3 - v2:
> o In patch #2, change the use of kvm_[err|info|debug].
> o In patch #3, add err removal in kvm_arch_commit_memory_region().
> o In patch #3, revert the changes to kvm_arch_vm_ioctl().
> o In patch #7, drop the merge of kvm_arch_vcpu_free() and pointer nullification.
> o Add patch #9.
> v2 - v1:
> o In patch #1, don't change the opening comment mark for kernel-doc comments.
> o In patch #1, to make long lines more readable, use local variables / macros.
> o In patch #1, slight format adjustments are made.
> o Use -M flag to generate patches (detect renames).
> o Add patch #8.
>
> Deng-Cheng Zhu (8):
> MIPS: KVM: Reformat code and comments
> MIPS: KVM: Use KVM internal logger
> MIPS: KVM: Simplify functions by removing redundancy
> MIPS: KVM: Remove unneeded volatile
> MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_"
> MIPS: KVM: Restore correct value for WIRED at TLB uninit
> MIPS: KVM: Fix memory leak on VCPU
> MIPS: KVM: Skip memory cleaning in kvm_mips_commpage_init()
>
> James Hogan (1):
> MIPS: KVM: Remove dead code of TLB index error in
> kvm_mips_emul_tlbwr()
>
> arch/mips/include/asm/kvm_host.h | 12 +-
> arch/mips/include/asm/r4kcache.h | 3 +
> arch/mips/kvm/Makefile | 8 +-
> arch/mips/kvm/{kvm_cb.c => callback.c} | 0
> arch/mips/kvm/commpage.c | 33 ++
> arch/mips/kvm/commpage.h | 24 +
> arch/mips/kvm/{kvm_mips_dyntrans.c => dyntrans.c} | 40 +-
> arch/mips/kvm/{kvm_mips_emul.c => emulate.c} | 539 +++++++++++-----------
> arch/mips/kvm/{kvm_mips_int.c => interrupt.c} | 47 +-
> arch/mips/kvm/{kvm_mips_int.h => interrupt.h} | 22 +-
> arch/mips/kvm/kvm_mips_comm.h | 23 -
> arch/mips/kvm/kvm_mips_commpage.c | 37 --
> arch/mips/kvm/kvm_mips_opcode.h | 24 -
> arch/mips/kvm/{kvm_locore.S => locore.S} | 55 ++-
> arch/mips/kvm/{kvm_mips.c => mips.c} | 227 +++++----
> arch/mips/kvm/opcode.h | 22 +
> arch/mips/kvm/{kvm_mips_stats.c => stats.c} | 28 +-
> arch/mips/kvm/{kvm_tlb.c => tlb.c} | 258 +++++------
> arch/mips/kvm/trace.h | 18 +-
> arch/mips/kvm/{kvm_trap_emul.c => trap_emul.c} | 109 +++--
> 20 files changed, 750 insertions(+), 779 deletions(-)
> rename arch/mips/kvm/{kvm_cb.c => callback.c} (100%)
> create mode 100644 arch/mips/kvm/commpage.c
> create mode 100644 arch/mips/kvm/commpage.h
> rename arch/mips/kvm/{kvm_mips_dyntrans.c => dyntrans.c} (79%)
> rename arch/mips/kvm/{kvm_mips_emul.c => emulate.c} (83%)
> rename arch/mips/kvm/{kvm_mips_int.c => interrupt.c} (85%)
> rename arch/mips/kvm/{kvm_mips_int.h => interrupt.h} (74%)
> delete mode 100644 arch/mips/kvm/kvm_mips_comm.h
> delete mode 100644 arch/mips/kvm/kvm_mips_commpage.c
> delete mode 100644 arch/mips/kvm/kvm_mips_opcode.h
> rename arch/mips/kvm/{kvm_locore.S => locore.S} (93%)
> rename arch/mips/kvm/{kvm_mips.c => mips.c} (83%)
> create mode 100644 arch/mips/kvm/opcode.h
> rename arch/mips/kvm/{kvm_mips_stats.c => stats.c} (63%)
> rename arch/mips/kvm/{kvm_tlb.c => tlb.c} (78%)
> rename arch/mips/kvm/{kvm_trap_emul.c => trap_emul.c} (83%)
>
I'll wait for v4 of these patches since James still had a few comments.
Paolo
prev parent reply other threads:[~2014-06-25 12:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 17:31 [PATCH v3 0/9] MIPS: KVM: Bugfixes and cleanups Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-24 17:31 ` [PATCH v3 1/9] MIPS: KVM: Reformat code and comments Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-24 23:13 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 2/9] MIPS: KVM: Use KVM internal logger Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 8:59 ` James Hogan
2014-06-25 8:59 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 3/9] MIPS: KVM: Simplify functions by removing redundancy Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:09 ` James Hogan
2014-06-25 9:09 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 4/9] MIPS: KVM: Remove unneeded volatile Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:09 ` James Hogan
2014-06-25 9:09 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 5/9] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:11 ` James Hogan
2014-06-25 9:11 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 6/9] MIPS: KVM: Restore correct value for WIRED at TLB uninit Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:24 ` James Hogan
2014-06-25 9:24 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:28 ` James Hogan
2014-06-25 9:28 ` James Hogan
2014-06-25 12:17 ` Paolo Bonzini
2014-06-27 23:47 ` Deng-Cheng Zhu
2014-06-27 23:47 ` Deng-Cheng Zhu
2014-06-24 17:31 ` [PATCH v3 8/9] MIPS: KVM: Skip memory cleaning in kvm_mips_commpage_init() Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:31 ` James Hogan
2014-06-25 9:31 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 9/9] MIPS: KVM: Remove dead code of TLB index error in kvm_mips_emul_tlbwr() Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 12:18 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AABE12.5080001@redhat.com \
--to=pbonzini@redhat.com \
--cc=dengcheng.zhu@imgtec.com \
--cc=gleb@kernel.org \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox