From: Paolo Bonzini <pbonzini@redhat.com>
To: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>,
David Daney <ddaney.cavm@gmail.com>
Cc: gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com,
james.hogan@imgtec.com, ralf@linux-mips.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_"
Date: Fri, 27 Jun 2014 16:27:52 +0200 [thread overview]
Message-ID: <53AD7F68.5000304@redhat.com> (raw)
In-Reply-To: <53ACA261.7040007@imgtec.com>
Il 27/06/2014 00:44, Deng-Cheng Zhu ha scritto:
>>>
>>>>
>>>> x86 calls these things irq.c and irq.h, perhaps that would be a little
>>>> better.
>>>
>>> There's also include/linux/irq.h
>>>
>>
>> Yes, I know.
>
> I simply wanted to let you know that if arch/mips/kvm/interrupt.h and
> include/linux/interrupt.h are consufing, then arch/x86/kvm/irq.h and
> include/linux/irq.h the same -- not even a little better.
And one of them is included as <linux/irq.h>, the other as "irq.h". So
there's no possibility of confusion.
"kvm_mips_" seems totally useless as a prefix. I'm ambivalent with
respect to removing the "kvm_" prefix; I'll apply the patch.
Paolo
next prev parent reply other threads:[~2014-06-27 14:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 19:11 [PATCH v4 0/7] MIPS: KVM: Bugfixes and cleanups Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-26 19:11 ` [PATCH v4 1/7] MIPS: KVM: Reformat code and comments Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-26 19:11 ` [PATCH v4 2/7] MIPS: KVM: Use KVM internal logger Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-26 19:11 ` [PATCH v4 3/7] MIPS: KVM: Simplify functions by removing redundancy Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-26 19:11 ` [PATCH v4 4/7] MIPS: KVM: Remove unneeded volatile Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-26 19:11 ` [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-26 19:28 ` David Daney
2014-06-26 19:55 ` Deng-Cheng Zhu
2014-06-26 19:55 ` Deng-Cheng Zhu
2014-06-26 21:55 ` David Daney
2014-06-26 22:44 ` Deng-Cheng Zhu
2014-06-26 22:44 ` Deng-Cheng Zhu
2014-06-26 23:53 ` Deng-Cheng Zhu
2014-06-26 23:53 ` Deng-Cheng Zhu
2014-06-27 14:27 ` Paolo Bonzini [this message]
2014-06-26 23:21 ` James Hogan
2014-06-27 0:32 ` David Daney
2014-06-26 19:11 ` [PATCH v4 6/7] MIPS: KVM: Skip memory cleaning in kvm_mips_commpage_init() Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-26 19:11 ` [PATCH v4 7/7] MIPS: KVM: Remove dead code of TLB index error in kvm_mips_emul_tlbwr() Deng-Cheng Zhu
2014-06-26 19:11 ` Deng-Cheng Zhu
2014-06-27 14:22 ` [PATCH v4 0/7] MIPS: KVM: Bugfixes and cleanups James Hogan
2014-06-27 14:22 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD7F68.5000304@redhat.com \
--to=pbonzini@redhat.com \
--cc=ddaney.cavm@gmail.com \
--cc=dengcheng.zhu@imgtec.com \
--cc=gleb@kernel.org \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox