Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Stefan Agner <stefan@agner.ch>
Cc: linux-mips@linux-mips.org
Subject: Re: dma: jz4740: Null pointer dereference
Date: Tue, 08 Jul 2014 18:50:31 +0200	[thread overview]
Message-ID: <53BC2157.1090809@metafoo.de> (raw)
In-Reply-To: <82522335fb2ef700d5a94f9217cbdff6@agner.ch>

On 07/08/2014 06:41 PM, Stefan Agner wrote:
> Hi Lars,
>
> While looking through different DMA drivers, just stumbled upon this
> inside jz4740_dma_chan_irq:
>
> if (chan->next_sg == chan->desc->num_sgs) {
> 	chan->desc = NULL;
> 	vchan_cookie_complete(&chan->desc->vdesc);
>                                           ^ null pointer dereference
> }
>
> I'm not sure what the correct fix is, hence I thought I report it to you
> as author of the driver.

Hi,

Thanks for the report. Yes this is a bug and I have a fix for it. Currently 
that codepath is not exercised though (no non-cyclic users of the JZ4740 
dmaengine driver), so the fix is not critical. It will be sent upstream soon 
together which a couple of other patches for this driver.

- Lars

      reply	other threads:[~2014-07-08 16:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 16:41 dma: jz4740: Null pointer dereference Stefan Agner
2014-07-08 16:50 ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BC2157.1090809@metafoo.de \
    --to=lars@metafoo.de \
    --cc=linux-mips@linux-mips.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox