From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Aurelien Jarno <aurelien@aurel32.net>,
Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: ZBOOT: add missing <linux/string.h> include
Date: Sun, 20 Jul 2014 21:50:01 +0400 [thread overview]
Message-ID: <53CC0149.3070902@cogentembedded.com> (raw)
In-Reply-To: <1405877939-28649-1-git-send-email-aurelien@aurel32.net>
Hello.
On 07/20/2014 09:38 PM, Aurelien Jarno wrote:
> Commit dc4d7b37 moves the string related functions into a separate file,
Please also specify that commit's summary line in parens.
> which might cause the following build error, depending on the
> configuration:
> | CC arch/mips/boot/compressed/decompress.o
> | In file included from linux/arch/mips/boot/compressed/../../../../lib/decompress_unxz.c:234:0,
> | from linux/arch/mips/boot/compressed/decompress.c:67:
> | linux/arch/mips/boot/compressed/../../../../lib/xz/xz_dec_stream.c: In function 'fill_temp':
> | linux/arch/mips/boot/compressed/../../../../lib/xz/xz_dec_stream.c:162:2: error: implicit declaration of function 'memcpy' [-Werror=implicit-function-declaration]
> | cc1: some warnings being treated as errors
> | linux/scripts/Makefile.build:308: recipe for target 'arch/mips/boot/compressed/decompress.o' failed
> | make[6]: *** [arch/mips/boot/compressed/decompress.o] Error 1
> | linux/arch/mips/Makefile:308: recipe for target 'vmlinuz' failed
> It doesn't not fail with the standard configuration, as when
> CONFIG_DYNAMIC_DEBUG is not set <linux/string.h> gets included in
> include/linux/dynamic_debug.h. There might be other way for it to
> get indirectly included.
> We can't add the include should not be added directly in xz_dec_stream.c
I can't parse that. :-)
> as some architectures might want to use a different version for the
> boot/ directory (see for example arch/x86/boot/string.h).
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
WBR, Sergei
prev parent reply other threads:[~2014-07-20 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 17:38 [PATCH] MIPS: ZBOOT: add missing <linux/string.h> include Aurelien Jarno
2014-07-20 17:50 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CC0149.3070902@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=aurelien@aurel32.net \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox