From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>,
linux-mips@linux-mips.org, "Ralf Baechle" <ralf@linux-mips.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Paul Walmsley <paul@pwsan.com>,
linux-soc@vger.kernel.org
Subject: Re: [PATCH] MIPS: BCM47XX: Move NVRAM header to the include/linux/
Date: Mon, 01 Dec 2014 09:23:55 +0100 [thread overview]
Message-ID: <547C259B.6000405@hauke-m.de> (raw)
In-Reply-To: <1417417098-8476-1-git-send-email-zajec5@gmail.com>
On 12/01/2014 07:58 AM, Rafał Miłecki wrote:
> There are two reasons for having this header in the common place:
> 1) Simplifying drivers that read NVRAM entries. We will be able to
> safely call bcm47xx_nvram_* functions without #ifdef-s.
> 2) Getting NVRAM driver out of MIPS arch code. This is needed to support
> BCM5301X arch which also requires this NVRAM driver. Patch for that
> will follow once we get is reviewed.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> Hi guys,
>
> As recently discussed (thanks Paul!), we will try yet another (3rd) path for our
> NVRAM driver, this time it will be drivers/firmware/.
> However this will require some time as I want to give ppl chance to review it
> and probably we will need to discuss it too.
>
> So meanwhile I'd like to move just a header file to the include/linux/. I
> believe it won't raise any/too many objections and it should strip down
> further discussions about bcm47xx_nvram.c.
> ---
> arch/mips/bcm47xx/board.c | 2 +-
> arch/mips/bcm47xx/nvram.c | 2 +-
> arch/mips/bcm47xx/setup.c | 1 -
> arch/mips/bcm47xx/sprom.c | 1 -
> arch/mips/bcm47xx/time.c | 1 -
> arch/mips/include/asm/mach-bcm47xx/bcm47xx.h | 1 +
> drivers/bcma/driver_mips.c | 2 +-
> drivers/net/ethernet/broadcom/b44.c | 2 +-
> drivers/net/ethernet/broadcom/bgmac.c | 2 +-
> drivers/ssb/driver_chipcommon_pmu.c | 2 +-
> drivers/ssb/driver_mipscore.c | 2 +-
> .../mach-bcm47xx => include/linux}/bcm47xx_nvram.h | 19 ++++++++++++++++---
> 12 files changed, 24 insertions(+), 13 deletions(-)
> rename {arch/mips/include/asm/mach-bcm47xx => include/linux}/bcm47xx_nvram.h (63%)
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
prev parent reply other threads:[~2014-12-01 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 6:58 [PATCH] MIPS: BCM47XX: Move NVRAM header to the include/linux/ Rafał Miłecki
2014-12-01 8:23 ` Hauke Mehrtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C259B.6000405@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=arnd@arndb.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-soc@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=ralf@linux-mips.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox