From: David Daney <ddaney.cavm@gmail.com>
To: Joshua Kinard <kumba@gentoo.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: CEVT: Make R4K's clockevent_device name more meaningful
Date: Fri, 12 Dec 2014 13:49:05 -0800 [thread overview]
Message-ID: <548B62D1.4000809@gmail.com> (raw)
In-Reply-To: <548B5EAC.9030403@gentoo.org>
On 12/12/2014 01:31 PM, Joshua Kinard wrote:
> Change the R4K clockevent device's name from "MIPS" to something a bit more
> meaningful, "CEVT-R4K".
>
This is visible to userspace, so how does changing this effect the
kernel <--> userspace ABI? Or in other words, what uses this, and could
changing it possibly break things?
David Daney
> Signed-off-by: Joshua Kinard <kumba@gentoo.org>
> ---
> arch/mips/kernel/cevt-r4k.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/cevt-r4k.c b/arch/mips/kernel/cevt-r4k.c
> index bc127e2..f531cac 100644
> --- a/arch/mips/kernel/cevt-r4k.c
> +++ b/arch/mips/kernel/cevt-r4k.c
> @@ -178,7 +178,7 @@ int r4k_clockevent_init(void)
>
> cd = &per_cpu(mips_clockevent_device, cpu);
>
> - cd->name = "MIPS";
> + cd->name = "CEVT-R4K";
> cd->features = CLOCK_EVT_FEAT_ONESHOT |
> CLOCK_EVT_FEAT_C3STOP |
> CLOCK_EVT_FEAT_PERCPU;
>
>
>
>
next prev parent reply other threads:[~2014-12-12 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 21:31 [PATCH] MIPS: CEVT: Make R4K's clockevent_device name more meaningful Joshua Kinard
2014-12-12 21:49 ` David Daney [this message]
2014-12-12 22:19 ` Joshua Kinard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548B62D1.4000809@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox