From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50AACC77B73 for ; Wed, 19 Apr 2023 16:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbjDSQu4 (ORCPT ); Wed, 19 Apr 2023 12:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232771AbjDSQuz (ORCPT ); Wed, 19 Apr 2023 12:50:55 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE2655B9 for ; Wed, 19 Apr 2023 09:50:52 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 87F115C008E; Wed, 19 Apr 2023 12:50:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 19 Apr 2023 12:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681923049; x=1682009449; bh=dLXXL9q6BarZExsPuZVOKkCgQK+Q0o/h/ZC r5b/C8mI=; b=UaM2/Vu6CVmlJvk2Kies9w5+uobY+s1IoR3w1Sj3u+ooEMRUd8q LxmhYZc1+J0TuSNhUNmVfspelTSBGX5ETTZT3Zzsgh1y6+qFFjFpcA2/ENBStsq6 rkzlHPSmlJb8kfPt78TDWad7bcDSBVmDCThnPqjGxKOqmxTIuyvN/f+xXxNliG2G JP4fOyA2Em0Lqwa/Di/fj4wJGEluXIMBxwwcn1fElSgTBUm8F8YuB7FWRhmdN/zj YSt7jOzE4Ks09IvwF4l4tFPLUC343Jy6l8C5/uH05JHc1WgMCXxz4Xn/uyWgn7wB thTnv3b2vHH72LBeRyFV6+4PK5/xLMxKgZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681923049; x=1682009449; bh=dLXXL9q6BarZExsPuZVOKkCgQK+Q0o/h/ZC r5b/C8mI=; b=Ph9/9UB+7iLMtCsD8z/5yfv+lizXHmTC4VaD34fe6q+/4QMywBl kdeVMZDRnib8//0nF/vBxkKB+PVnyN+oO/oKp3o8fS/I7V2SHoeNOCQU6asInTse 00ZL31li8fFi43+DcmJTMGJR/wexjSW2pfVeA/6NzAoCalBsOCWAJ8LKhepMlnVd 5YUQYQgBDCg5pCS8cCaBIFhi5oCXNKz0wz01LJFtiNh22ALU2Fdt7F8bvwI2BNRL zQXRIuNwVSdlRhprHZNFFSPKz5/MMjaXaH7qHCfOIzQDZY2Bu9gVsZ6kEZ3CqR6J GsFBzzqLw9l0B3hzA3petE5fPvtR2mHR2hA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedttddguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtjeenucfhrhhomheplfhi rgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhmqe enucggtffrrghtthgvrhhnpeduleefueeggfeitdfgkeeukeetjedvveelieeviedvueek ueeljefhleeugefhudenucffohhmrghinhepghhithhhuhgsrdgtohhmpdifihhkihhpvg guihgrrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepjhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 12:50:48 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: [PATCH v2 6/7] MIPS: Fallback CPU -march CFLAG to ISA level if unsupported From: Jiaxun Yang In-Reply-To: Date: Wed, 19 Apr 2023 17:50:36 +0100 Cc: "linux-mips@vger.kernel.org" , llvm@lists.linux.dev, Thomas Bogendoerfer , Nathan Chancellor Content-Transfer-Encoding: quoted-printable Message-Id: <550FCA0F-2C48-4133-85B0-D9494CC1C23C@flygoat.com> References: <20230414080701.15503-1-jiaxun.yang@flygoat.com> <20230414080701.15503-7-jiaxun.yang@flygoat.com> To: Nick Desaulniers X-Mailer: Apple Mail (2.3731.500.231) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org > 2023=E5=B9=B44=E6=9C=8818=E6=97=A5 21:07=EF=BC=8CNick Desaulniers = =E5=86=99=E9=81=93=EF=BC=9A >=20 > On Fri, Apr 14, 2023 at 1:07=E2=80=AFAM Jiaxun Yang = wrote: >>=20 >> LLVM does not implement some of -march options. However those options >> are not mandatory for kernel to build for those CPUs. >>=20 >> Fallback -march CFLAG to ISA level if unsupported by toolchain so >> we can get those kernel to build with LLVM. >>=20 >> Link: https://github.com/ClangBuiltLinux/linux/issues/1544 >> Reported-by: Nathan Chancellor >> Signed-off-by: Jiaxun Yang >=20 > Thanks for the patch! Maybe it's more obvious to folks who work on > mips, but how did you determine that say `p5600` is `mips32r5` or > `r10000` is `mips4`? Wikipedia [1] should fit the purpose. >=20 > Is there a table somewhere you used as a reference? Including such > info in the commit message would help reviewers such as myself verify > the patch. >=20 > Also, in v1, you mentioned that -mtune is not a substitute. It would > be good to record that info in the commit message as well. Thanks for the input! Will reword in next rev. >=20 [1]: https://en.wikipedia.org/wiki/List_of_MIPS_architecture_processors Thanks - Jiaxun=