Re: [PATCH RFC v3 4/4] MIPS: BMIPS: accept UHI interface for passing a dtb

[Florian Fainelli <f.fainelli@gmail.com>]

Le 12/04/2015 03:25, Jonas Gorski a écrit :
> Detect and use passed dtb address using the UHI interface. This allows for
> booting with a vmlinux.bin appended dtb instead of using a built-in one.

No particular objections to this change, current platforms support by
this change fall under 3 categories:

- BCM7xxx using a CFE providing a firmware interface you call into using
code from arch/mips/fw/cfe/
- BCM63xx CFE
- BCM33xx using Aeolus [1]

The first two are likely not going to be changed since these are
currently deployed products/systems, however the latter could be changed
to match UHI as Kevin proposed a while ago.

> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> ---
>  arch/mips/bmips/setup.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
> index fae800e..526ec27 100644
> --- a/arch/mips/bmips/setup.c
> +++ b/arch/mips/bmips/setup.c
> @@ -149,6 +149,8 @@ void __init plat_mem_setup(void)
>  	/* intended to somewhat resemble ARM; see Documentation/arm/Booting */
>  	if (fw_arg0 == 0 && fw_arg1 == 0xffffffff)
>  		dtb = phys_to_virt(fw_arg2);
> +	else if (fw_arg0 == -2) /* UHI interface */
> +		dtb = (void *)fw_arg1;
>  	else if (__dtb_start != __dtb_end)
>  		dtb = (void *)__dtb_start;
>  	else
>