From: Niklas Cassel <niklas.cassel@axis.com>
To: Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>
Cc: Niklas Cassel <niklass@axis.com>
Subject: Re: [PATCH] MIPS: Fix up obsolete cpu_set usage
Date: Wed, 29 Apr 2015 11:38:55 +0200 [thread overview]
Message-ID: <5540A6AF.5090701@axis.com> (raw)
In-Reply-To: <1430256863-811-1-git-send-email-ezequiel.garcia@imgtec.com>
On 04/28/2015 11:34 PM, Ezequiel Garcia wrote:
> cpu_set was removed (along with a bunch of cpumask helpers) by
> commit 2f0f267ea072 ("cpumask: remove deprecated functions.").
>
> Fix this by replacing cpu_set with cpumask_set_cpu. Without this
> fix the following error is triggered when CONFIG_MIPS_MT_FPAFF=y.
>
> arch/mips/kernel/smp-cps.c: In function 'cps_smp_setup':
> arch/mips/kernel/smp-cps.c:95:3: error: implicit declaration of function 'cpu_set' [-Werror=implicit-function-declaration]
>
> Fixes: 90db024f140d ("MIPS: smp-cps: cpu_set FPU mask if FPU present")
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Acked-by: Niklas Cassel <niklass@axis.com>
> ---
> This is a fix for v4.1.
>
> arch/mips/kernel/smp-cps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
> index 7e011f9..4251d39 100644
> --- a/arch/mips/kernel/smp-cps.c
> +++ b/arch/mips/kernel/smp-cps.c
> @@ -92,7 +92,7 @@ static void __init cps_smp_setup(void)
> #ifdef CONFIG_MIPS_MT_FPAFF
> /* If we have an FPU, enroll ourselves in the FPU-full mask */
> if (cpu_has_fpu)
> - cpu_set(0, mt_fpu_cpumask);
> + cpumask_set_cpu(0, &mt_fpu_cpumask);
> #endif /* CONFIG_MIPS_MT_FPAFF */
> }
>
>
prev parent reply other threads:[~2015-04-29 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 21:34 [PATCH] MIPS: Fix up obsolete cpu_set usage Ezequiel Garcia
2015-04-28 21:34 ` Ezequiel Garcia
2015-04-29 9:38 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5540A6AF.5090701@axis.com \
--to=niklas.cassel@axis.com \
--cc=ezequiel.garcia@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=niklass@axis.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox