From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 30 Apr 2015 14:03:08 +0200 (CEST) Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:41356 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27012289AbbD3MDH2yrH8 (ORCPT ); Thu, 30 Apr 2015 14:03:07 +0200 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Apr 2015 13:03:03 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 30 Apr 2015 13:03:01 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7AE841B08075 for ; Thu, 30 Apr 2015 13:03:40 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3UC30tE54984880 for ; Thu, 30 Apr 2015 12:03:00 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3UC2xDg003601 for ; Thu, 30 Apr 2015 08:03:00 -0400 Received: from oc1450873852.ibm.com (dyn-9-152-224-132.boeblingen.de.ibm.com [9.152.224.132]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t3UC2x1M003563; Thu, 30 Apr 2015 08:02:59 -0400 Message-ID: <554219F2.9020805@de.ibm.com> Date: Thu, 30 Apr 2015 14:02:58 +0200 From: Christian Borntraeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Paolo Bonzini CC: KVM , kvm-ppc@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-mips@linux-mips.org, Cornelia Huck , Alexander Graf Subject: Re: [PATCH 1/2] KVM: provide irq_unsafe kvm_guest_{enter|exit} References: <1430394211-25209-1-git-send-email-borntraeger@de.ibm.com> <1430394211-25209-2-git-send-email-borntraeger@de.ibm.com> <554216EC.6070406@redhat.com> <554219A1.8050006@de.ibm.com> In-Reply-To: <554219A1.8050006@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15043012-0041-0000-0000-00000440519D Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 47173 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: borntraeger@de.ibm.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Am 30.04.2015 um 14:01 schrieb Christian Borntraeger: > Am 30.04.2015 um 13:50 schrieb Paolo Bonzini: >> >> >> On 30/04/2015 13:43, Christian Borntraeger wrote: >>> +/* must be called with irqs disabled */ >>> +static inline void __kvm_guest_enter(void) >>> { >>> - unsigned long flags; >>> - >>> - BUG_ON(preemptible()); >> >> Please keep the BUG_ON() in kvm_guest_enter. Otherwise looks good, thanks! Ah, you mean have the BUG_ON in the non underscore version? Yes, makes sense.