Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: nick <xerofoify@gmail.com>
To: Joshua Kinard <kumba@gentoo.org>, ralf@linux-mips.org
Cc: akpm@linux-foundation.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips:Fix build error for ip32_defconfig configuration
Date: Fri, 08 May 2015 10:13:48 -0400	[thread overview]
Message-ID: <554CC49C.1010204@gmail.com> (raw)
In-Reply-To: <554C4D4E.6040904@gentoo.org>



On 2015-05-08 01:44 AM, Joshua Kinard wrote:
> On 05/07/2015 20:52, Nicholas Krause wrote:
>> This fixes the make error when building the ip32_defconfig
>> configuration due to using sgio2_cmos_devinit rather then
>> the correct function,sgio2_rtc_devinit in a device_initcall
>> below this function's definition.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  arch/mips/sgi-ip32/ip32-platform.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/mips/sgi-ip32/ip32-platform.c b/arch/mips/sgi-ip32/ip32-platform.c
>> index 0134db2..2a7efcb 100644
>> --- a/arch/mips/sgi-ip32/ip32-platform.c
>> +++ b/arch/mips/sgi-ip32/ip32-platform.c
>> @@ -130,9 +130,9 @@ struct platform_device ip32_rtc_device = {
>>  	.resource		= ip32_rtc_resources,
>>  };
>>  
>> -+static int __init sgio2_rtc_devinit(void)
>> +static  __init int sgio2_rtc_devinit(void)
>>  {
>>  	return platform_device_register(&ip32_rtc_device);
>>  }
>>  
>> -device_initcall(sgio2_cmos_devinit);
>> +device_initcall(sgio2_rtc_devinit);
>>
> 
> I believe I sent this patch in already, back on 04/19/2015.  Didn't get an
> acknowledgement on it from akpm, though.
> 
> --J
> 
That's fine, I didn't known about that. 
Sorry Nick

      reply	other threads:[~2015-05-08 14:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  0:52 [PATCH] mips:Fix build error for ip32_defconfig configuration Nicholas Krause
2015-05-08  5:44 ` Joshua Kinard
2015-05-08 14:13   ` nick [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554CC49C.1010204@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kumba@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox